public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Baurzhan Ismagulov <ibr@radix50.net>
To: Henning Schild <henning.schild@siemens.com>
Cc: Anton Mikanovich <amikan@ilbers.de>,
	isar-users@googlegroups.com, Yuri Adamov <yadamov@ilbers.de>
Subject: Re: [PATCH v2] isar-bootstrap: Run gpg-agent before starting apt-key
Date: Wed, 20 Jan 2021 12:20:08 +0100	[thread overview]
Message-ID: <20210120112008.GX22444@yssyq.m.ilbers.de> (raw)
In-Reply-To: <20210120115542.074eeef1@md1za8fc.ad001.siemens.net>

On Wed, Jan 20, 2021 at 11:55:42AM +0100, Henning Schild wrote:
> > +            MY_GPGHOME=$(chroot "${ROOTFSDIR}" mktemp -d /tmp/gpghomeXXXXXXXXXX)
...
> > +            chroot "${ROOTFSDIR}" /bin/rm -rf "${MY_GPGHOME}"
> 
> this should be guarded making sure MY_GPGHOME is indeed a directory
> with a matching name ... would be a pity if for some reason it would be
> i.e. "/usr" or even only "/tmp"

That comes from mktemp -d. If that succeeds, my understanding is it's a
directory. Or do I miss anything?

With kind regards,
Baurzhan.

  reply	other threads:[~2021-01-20 11:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:20 Anton Mikanovich
2021-01-19 12:54 ` Jan Kiszka
2021-01-19 14:24   ` Anton Mikanovich
2021-01-20  9:58     ` Jan Kiszka
2021-01-20 11:04       ` Henning Schild
2021-01-20 11:35         ` Baurzhan Ismagulov
2021-01-20 12:15           ` Henning Schild
2021-01-24 11:28             ` Baurzhan Ismagulov
2021-01-20 10:55 ` Henning Schild
2021-01-20 11:20   ` Baurzhan Ismagulov [this message]
2021-01-20 11:27     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120112008.GX22444@yssyq.m.ilbers.de \
    --to=ibr@radix50.net \
    --cc=amikan@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=yadamov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox