From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: Anton Mikanovich <amikan@ilbers.de>,
isar-users@googlegroups.com, Yuri Adamov <yadamov@ilbers.de>
Subject: Re: [PATCH v2] isar-bootstrap: Run gpg-agent before starting apt-key
Date: Wed, 20 Jan 2021 12:04:57 +0100 [thread overview]
Message-ID: <20210120120457.5fb65262@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <03dd4a4a-0d31-ebbe-30da-516445e12c6e@siemens.com>
Am Wed, 20 Jan 2021 10:58:55 +0100
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> On 19.01.21 15:24, Anton Mikanovich wrote:
> > 19.01.2021 15:54, Jan Kiszka wrote:
> >> On 19.01.21 12:20, Anton Mikanovich wrote:
> >>> From: Yuri Adamov <yadamov@ilbers.de>
> >>>
> >>> Building rpi-stretch natively (under qemu) sometimes fails with:
> >>>
> >>> gpg: can't connect to the agent: IPC connect call failed
> >>>
> >>> gpg starts gpg-agent and times out after 5 s. This value is
> >>> hard-coded.
> >>>
> >>> Besides, leaving running gpg-agent processes is not clean and
> >>> prevents unmounting of filesystems.
> >>>
> >>> This patch starts and stops the agent manually.
> >>>
> >>> gnupg now appended to package list unconditionally because
> >>> gpg-agent is used in every isar_bootstrap run.
> >> Looks good - except that I do not get why makingthis
> >> unconditionally. That looks still like a lazy approach to me. Or
> >> do I miss some technical need for that (which is not documented
> >> here)?
> >>
> >> Jan
> >
> > It's used unconditionally inside isar_bootstrap(), so appended it
> > also unconditionally.
> >
>
> Yes, this is the laziness I'm talking about: I don't see WHY we need
> to use it unconditionally now.
It seems like a functional change. We did use the native agent before
and now never use it.
But i guess the native agent is potentially still used i.e. when
building packages.
Not sure i like the idea of special casing this one potential gpg user.
Henning
> Jan
>
next prev parent reply other threads:[~2021-01-20 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 11:20 Anton Mikanovich
2021-01-19 12:54 ` Jan Kiszka
2021-01-19 14:24 ` Anton Mikanovich
2021-01-20 9:58 ` Jan Kiszka
2021-01-20 11:04 ` Henning Schild [this message]
2021-01-20 11:35 ` Baurzhan Ismagulov
2021-01-20 12:15 ` Henning Schild
2021-01-24 11:28 ` Baurzhan Ismagulov
2021-01-20 10:55 ` Henning Schild
2021-01-20 11:20 ` Baurzhan Ismagulov
2021-01-20 11:27 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120120457.5fb65262@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=yadamov@ilbers.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox