Re: [PATCH v2] isar-bootstrap: Run gpg-agent before starting apt-key

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 20 Jan 2021 12:20:08 +0100
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Wed, Jan 20, 2021 at 11:55:42AM +0100, Henning Schild wrote:
> > > +            MY_GPGHOME=$(chroot "${ROOTFSDIR}" mktemp -d
> > > /tmp/gpghomeXXXXXXXXXX)  
> ...
> > > +            chroot "${ROOTFSDIR}" /bin/rm -rf "${MY_GPGHOME}"  
> > 
> > this should be guarded making sure MY_GPGHOME is indeed a directory
> > with a matching name ... would be a pity if for some reason it
> > would be i.e. "/usr" or even only "/tmp"  
> 
> That comes from mktemp -d. If that succeeds, my understanding is it's
> a directory. Or do I miss anything?

That is the impression you can get when reading the code. But under the
assumption that the script will indeed fail if mktemp fails, and that
nothing else overwrites the variable ... even by accident. Now and in
the future when people need to touch this code again.

Just a safeguard suggestion, i do not feel strong about it.

Henning

> With kind regards,
> Baurzhan.