public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>,
	Anton Mikanovich <amikan@ilbers.de>,
	<isar-users@googlegroups.com>, Yuri Adamov <yadamov@ilbers.de>
Subject: Re: [PATCH v2] isar-bootstrap: Run gpg-agent before starting apt-key
Date: Wed, 20 Jan 2021 13:15:37 +0100	[thread overview]
Message-ID: <20210120131537.4d99672a@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20210120113530.GY22444@yssyq.m.ilbers.de>

Am Wed, 20 Jan 2021 12:35:30 +0100
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Wed, Jan 20, 2021 at 12:04:57PM +0100, Henning Schild wrote:
> > It seems like a functional change. We did use the native agent
> > before and now never use it.  
> 
> This is a good point. Yes, we've focused on the CI and not on the
> interactive build. What do you mean by "native", is it the agent
> running on my host as my desktop user? If that is required, it would
> add some more complexity...

I was talking about an agent potentially already running on that host
under the user calling isar. (so i guess root)

> > But i guess the native agent is potentially still used i.e. when
> > building packages.  
> 
> This is also a good point. We need agent management, among other
> reasons, for clean unmounting of the filesystems. If the agent is
> started elsewhere, we should handle that, too. We used to
> dpkg-buildpackage -uc -us -- we'll have check that after this patch.

I would actually assume that all the sudo and chroot stuff would
automatically avoid accidental agent reuse from root on the host. But i
am not sure about it.

It could also be that the patch should just kill a potential agent in
the chroot with the command i suggested.

But as longs as its not understood where that problematic agent is
really coming from, i would refrain from proposing patches that are not
fully understood either.

Henning

> 
> With kind regards,
> Baurzhan.


  reply	other threads:[~2021-01-20 12:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:20 Anton Mikanovich
2021-01-19 12:54 ` Jan Kiszka
2021-01-19 14:24   ` Anton Mikanovich
2021-01-20  9:58     ` Jan Kiszka
2021-01-20 11:04       ` Henning Schild
2021-01-20 11:35         ` Baurzhan Ismagulov
2021-01-20 12:15           ` Henning Schild [this message]
2021-01-24 11:28             ` Baurzhan Ismagulov
2021-01-20 10:55 ` Henning Schild
2021-01-20 11:20   ` Baurzhan Ismagulov
2021-01-20 11:27     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120131537.4d99672a@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=yadamov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox