From: Baurzhan Ismagulov <ibr@radix50.net>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com,
Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: Re: [PATCHv2] wic/plugins: fix kernel version detection for bios
Date: Fri, 5 Feb 2021 09:41:28 +0100 [thread overview]
Message-ID: <20210205084114.GE20742@yssyq.m.ilbers.de> (raw)
In-Reply-To: <20210204163912.31570-1-henning.schild@siemens.com>
On Thu, Feb 04, 2021 at 05:39:12PM +0100, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
>
> The mechanism used to "cut off the end" seems to cut off too much.
>
> >>> "vmlinuz-4.19.0-14-amd64".strip('-' + 'amd64')
> 'vmlinuz-4.19.0-1'
>
> But indeed we would hope for 'vmlinuz-4.19.0-14'. This is a fix that
> should be aplied asap, it seems to affect all "even" kernel revisions,
> "odd" is odly enough no problem.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
Regarding the commit message, I'd suggest:
* Mentioning the user-visible failure.
* Dropping the "This is a fix that should be aplied asap" part.
* "odly" -> "oddly".
We'll provide an update regarding the code.
With kind regards,
Baurzhan.
prev parent reply other threads:[~2021-02-05 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 16:39 Henning Schild
2021-02-04 16:51 ` IMPORTANT " Henning Schild
2021-02-04 17:04 ` Baurzhan Ismagulov
2021-02-04 19:37 ` Henning Schild
2021-02-05 8:41 ` Baurzhan Ismagulov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205084114.GE20742@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=Vijaikumar_Kanagarajan@mentor.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox