From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6925447760545054720
X-Received: by 2002:a2e:9252:: with SMTP id v18mr2138861ljg.352.1612514492262;
        Fri, 05 Feb 2021 00:41:32 -0800 (PST)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a05:6512:6d4:: with SMTP id u20ls1816175lff.1.gmail; Fri, 05
 Feb 2021 00:41:31 -0800 (PST)
X-Google-Smtp-Source: ABdhPJz1fZ6wh1cMuGgVemfwFRsm46pOuS+T+b/RNLvQgHYe42GSyrLFYZu9IayCQWwthNwOul6L
X-Received: by 2002:ac2:4c8c:: with SMTP id d12mr1863440lfl.361.1612514491207;
        Fri, 05 Feb 2021 00:41:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612514491; cv=none;
        d=google.com; s=arc-20160816;
        b=lJGaFkr76gOuSGzwFnihKkd9R8pm1CwHzqmI4nawzaucUuPs1xfDix1zzpTn/UoSqd
         ycRnIWnjMczK7HUsNRIuqYzYMsBNSYTxTc0sso/SzUpxI5c48xUPhgM4gmSpq97Y7mcm
         rAmknyyREgS0JuK7L4CKsxcDBSZ4ydJ1UEy/Vad2EibKuE7ZeCo9zYwhHoOsP6nnvRwb
         nJwWA0bMJiTN9sORZd2XRknY3+jVQp5FAcw21tzMN5MPlwjshMU7jAbZi3iFdwYu1Th0
         8qLv1nvZQDjRrjSK4XydS6s57jRB92TbdoDk6l2IzJ/CkJsqbv6fmKS07JTMb9HSguY5
         q8eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:cc:to:from:date;
        bh=iZmc3GTv+9KIdPMR39eUHMT2Jxc8QgSrkpr7AA/gfyc=;
        b=GfV+S0DQD7Uqemt53UgQkIxSqsfQ/DJW9ww5NRlQCnwMOiu+bCT6QZX1hVjDiUiurM
         R1aECUZ2+JI4e+yHP7EAMJiS2AT/HXm0G39VyXp/lU24MmDSl+5gF4i4NnacTiSmVKxw
         Y4RTsUh8f0wyR8Miv1aKz9dB4Pd8SfVO+rUkISBR89hxxwjyPAVqKrTAVcEPLOnBmoOV
         zU0DFWQpDP5GtI29UVsBm8K5fns61zjIZncCvy080mdaFKRNPdlbjb9+swEUWeuEcMs7
         NrRnMgnHlvF9TERpHvjlyyUeh+ULbNI7LPqIK5wzWtjzvrbm5KCcyyyzFUSn3yf3TIvz
         Tevw==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Return-Path: <ibr@radix50.net>
Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166])
        by gmr-mx.google.com with ESMTPS id h19si274548lfl.4.2021.02.05.00.41.30
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
        Fri, 05 Feb 2021 00:41:31 -0800 (PST)
Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166;
Authentication-Results: gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52])
	(authenticated bits=0)
	by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1158fRZi019951
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Fri, 5 Feb 2021 09:41:30 +0100
Date: Fri, 5 Feb 2021 09:41:28 +0100
From: Baurzhan Ismagulov <ibr@radix50.net>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com,
        Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: Re: [PATCHv2] wic/plugins: fix kernel version detection for bios
Message-ID: <20210205084114.GE20742@yssyq.m.ilbers.de>
Mail-Followup-To: Henning Schild <henning.schild@siemens.com>,
	isar-users@googlegroups.com,
	Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
References: <20210204163912.31570-1-henning.schild@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210204163912.31570-1-henning.schild@siemens.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED
	autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de
X-TUID: dCo851k1xc82

On Thu, Feb 04, 2021 at 05:39:12PM +0100, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> The mechanism used to "cut off the end" seems to cut off too much.
> 
> >>> "vmlinuz-4.19.0-14-amd64".strip('-' + 'amd64')
> 'vmlinuz-4.19.0-1'
> 
> But indeed we would hope for 'vmlinuz-4.19.0-14'. This is a fix that
> should be aplied asap, it seems to affect all "even" kernel revisions,
> "odd" is odly enough no problem.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Regarding the commit message, I'd suggest:

* Mentioning the user-visible failure.

* Dropping the "This is a fix that should be aplied asap" part.

* "odly" -> "oddly".

We'll provide an update regarding the code.

With kind regards,
Baurzhan.