From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCHv3] wic/plugins: fix kernel version detection for bios
Date: Fri, 5 Feb 2021 15:59:54 +0100 [thread overview]
Message-ID: <20210205145954.GG20742@yssyq.m.ilbers.de> (raw)
In-Reply-To: <420a0704-56cb-fad5-2d51-a6cdffb7bc83@ilbers.de>
On Fri, Feb 05, 2021 at 05:45:27PM +0300, Anton Mikanovich wrote:
> Thanks for finding.
> This issue can be found not on even kernel version numbers, but on all
> version end on 4 and 6, because '-amd64' is used as char values to be
> stripped both from begin and from end. Usage of strip() looks completely
> wrong here.
> Looks good to me.
If there are no objections, I'd suggest to apply this on Monday.
1. Henning, would it be ok if we commit with the following message:
From: Henning Schild <henning.schild@siemens.com>
When building an image with legacy bios using wic, wic can fail to pick
up the initrd.
ERROR: _exec_cmd: install -m 0644 /build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64 /tmp/tmp.7x9N9Wo4wZ/bla-image-debian-buster-qemux86-64.wic/tmp.wic.r10macew/hdd/boot/initrd.img-4.19.0-1-amd64 returned '1' instead of 0
output: install: cannot stat '/build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64': No such file or directory
The mechanism used to "cut off the end" seems to cut off too much.
>>> "vmlinuz-4.19.0-14-amd64".strip('-' + 'amd64')
'vmlinuz-4.19.0-1'
But indeed we would hope for 'vmlinuz-4.19.0-14'. The issue affects all
versions ending with 4 and 6, because '-amd64' is used as a set of
characters to be stripped anywhere in the string. Using strip() is
completely wrong here.
Signed-off-by: Henning Schild <henning.schild@siemens.com>
2. We haven't seen this on Isar CI. Care to add a test case?
With kind regards,
Baurzhan.
next prev parent reply other threads:[~2021-02-05 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 11:48 Henning Schild
2021-02-05 14:45 ` Anton Mikanovich
2021-02-05 14:59 ` Baurzhan Ismagulov [this message]
2021-02-05 19:55 ` Henning Schild
2021-02-05 20:07 ` Henning Schild
2021-02-10 9:19 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205145954.GG20742@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox