From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6925447760545054720 X-Received: by 2002:aa7:c6d9:: with SMTP id b25mr5404011eds.84.1612555655601; Fri, 05 Feb 2021 12:07:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:add7:: with SMTP id lb23ls4077285ejb.2.gmail; Fri, 05 Feb 2021 12:07:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYvgbHu+FDUWePBvgid0iT7T7VDD0nWKgHTonh941AdRrSTKVsLIE/yfhT2amK/9dfZzIz X-Received: by 2002:a17:906:c04f:: with SMTP id bm15mr5628379ejb.364.1612555654768; Fri, 05 Feb 2021 12:07:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612555654; cv=none; d=google.com; s=arc-20160816; b=AOZ8Hjk7nf+VkWwMqhl54ZUSdgflfUl5g5RPv8KcBZhtOg6Tai0IqFRoR6qf35zN5Z eOwr33pJGRrtJuZjVoAlJpyQv8IoMCfR0LA9iwa9ZPLwHgRIShlPIULoNfhDZSBbMAdp K9T8HYKal5jIW4Nxsf6gq+szAsYVLwvuhaJFb6XFUGM8eO3OkHIaKNth8M0hl2NvMVrw keSlnvp46aqlPGaT9WNhGcjmlEedXyTQtKskJtlCbmDu25DJK6BVyra5HoHJkXQACdDQ bB2NI8eIkN9zJt7Xh/wYWYaaLk5HegQkDs6g/509OLVizULbYUePmZpNp+cb2+MpjCmo gwNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=yqj0CRRsCbOzYRiporSUeWXBy22O7Ft+k9GOd2StKWw=; b=osQEc8zBXR3gxJbqYMnMXMG/vqkP/DcwkJbv8yMkMSNNY2WnSSdqNAphjBkOprcWtS +cUlp+XVby4Q2eG3vtEd0bQV4jpB5dtSCb8LDqkO0jBk1gyVa0J6ENT+LuplSEk1LJr/ ZEjdz7lpf5ZEOudCBqcWxxWnfUGjBOY49SBNYKbtw7CO9w/1uERMV8GsniVfqr2smPmr HLsh5FtSDcloBAbP7s9GkmPMwOQCIGIBSHHZjxgVkohtIoIivndtQAzo9cx8o1573BXb /2usjr2SBdD0/fegx/dL6U4ciI7t87UvYRavUzZYxnsukokgVEp8hTXsGEyDtLEUI+BH +fpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id z69si232869ede.1.2021.02.05.12.07.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Feb 2021 12:07:34 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 115K7Ywx017913 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 5 Feb 2021 21:07:34 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.126.146]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 115K7Xuf025388; Fri, 5 Feb 2021 21:07:33 +0100 Date: Fri, 5 Feb 2021 21:07:32 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: isar-users@googlegroups.com Subject: Re: [PATCHv3] wic/plugins: fix kernel version detection for bios Message-ID: <20210205210732.7a358184@md1za8fc.ad001.siemens.net> In-Reply-To: <20210205205542.09c2f41a@md1za8fc.ad001.siemens.net> References: <20210205114812.6370-1-henning.schild@siemens.com> <420a0704-56cb-fad5-2d51-a6cdffb7bc83@ilbers.de> <20210205145954.GG20742@yssyq.m.ilbers.de> <20210205205542.09c2f41a@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: fC3DTFpr53Rd Am Fri, 5 Feb 2021 20:55:42 +0100 schrieb "[ext] Henning Schild" : > Am Fri, 5 Feb 2021 15:59:54 +0100 > schrieb Baurzhan Ismagulov : > > > On Fri, Feb 05, 2021 at 05:45:27PM +0300, Anton Mikanovich wrote: > > > Thanks for finding. > > > This issue can be found not on even kernel version numbers, but on > > > all version end on 4 and 6, because '-amd64' is used as char > > > values to be stripped both from begin and from end. Usage of > > > strip() looks completely wrong here. > > > Looks good to me. > > > > If there are no objections, I'd suggest to apply this on Monday. > > Given that it can not be reproduced by you, i would take back the > "rush". Probably still worth merging, my layer is currently fixed with > a backport using the kas patch mechanism. > > > > > 1. Henning, would it be ok if we commit with the following message: > > > > Please send me a diff or go ahead and change it. > > > From: Henning Schild > > > > When building an image with legacy bios using wic, wic can fail to > > pick up the initrd. > > > > ERROR: _exec_cmd: install -m 0644 > > /build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64 > > /tmp/tmp.7x9N9Wo4wZ/bla-image-debian-buster-qemux86-64.wic/tmp.wic.r10macew/hdd/boot/initrd.img-4.19.0-1-amd64 > > returned '1' instead of 0 output: install: cannot stat > > '/build/tmp/work/debian-buster-amd64/bla-image-qemux86-64-wic-img/0.2-r0/rootfs/boot/initrd.img-4.19.0-1-amd64': > > No such file or directory > > > > The mechanism used to "cut off the end" seems to cut off too much. > > > > >>> "vmlinuz-4.19.0-14-amd64".strip('-' + 'amd64') > > 'vmlinuz-4.19.0-1' > > > > But indeed we would hope for 'vmlinuz-4.19.0-14'. The issue affects > > all versions ending with 4 and 6, because '-amd64' is used as a set > > of characters to be stripped anywhere in the string. Using strip() > > is completely wrong here. > > > > Signed-off-by: Henning Schild > > > > > > 2. We haven't seen this on Isar CI. Care to add a test case? > > I am a big fan of test cases, but am not sure how to add one here. As > far as i understand it the pipeline should fail for amd64. And for all > other arches that have numbers that could be in the revisions. > > So i would say there is no need, sorry i do not understand why you do > not see it. Might also be related to the python version, but we should > be using the one from the buildchroot. I think the regular ci does not find it because the arch is "i386" or "686-pae", non of the numbers in "14". So a testcase would likely be adding "amd64" for WKS_FILE ?= "directdisk-isar". Or waiting for a "-16" kernel which should hit "386" "686" and "amd64". Henning > Henning > > > > > With kind regards, > > Baurzhan. > > >