Re: [PATCH 1/3] dpkg: adjust task order to allow using "git" for patching

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 8 Feb 2021 19:06:56 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> 22.01.2021 16:40, Henning Schild wrote:
> > Am Fri, 22 Jan 2021 11:53:58 +0100
> > schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> >  
> >> On 22.01.21 09:42, [ext] Henning Schild wrote:  
> >>> From: Henning Schild <henning.schild@siemens.com>
> >>>
> >>> The adjust_git task breaks the git tree for use outside the
> >>> buildchroot. And our patch implementation supports using "git am"
> >>> when setting PATCHTOOL = "git". In order to actually apply git
> >>> patches we have to adjust after patching.  
> >> That will likely not work as is when rerunning the job for a
> >> partial rebuild, e.g. after adding a patch and not changing the
> >> git URL. We now need a "restore_git" prior to patch, no?  
> > I was also afraid of that. So i tried modifying a patch, which
> > triggerd a new fetch/unpack cycle and was fine. I guess adding a
> > patch will do the same.
> > Changing the patch function would become problematic, but that is a
> > task for isar developers.
> >
> > So i am almost certain that will not cause fun on partial rebuilds.
> >
> > Henning
> >  
> If you've already tested partial rebuild and there is no issues can
> we proceed with apply?

I think so. In fact just backported this to a layer where at again
performed as expected.

Henning