From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6920502129401528320 X-Received: by 2002:a2e:3207:: with SMTP id y7mr11412451ljy.190.1612801002770; Mon, 08 Feb 2021 08:16:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b4d1:: with SMTP id r17ls533840ljm.10.gmail; Mon, 08 Feb 2021 08:16:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaaoolZLadcfwNRuKmywXxXL7KnSkYVbfTg6Ot14iZOY9o2BQPe3lJDhZWuF6RSXb0cMnE X-Received: by 2002:a2e:b0f9:: with SMTP id h25mr440466ljl.33.1612801001791; Mon, 08 Feb 2021 08:16:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612801001; cv=none; d=google.com; s=arc-20160816; b=Csvnmbm+xZY21dhtrRSyKInwaK8PsaGpQjaFVL65GWhCodGJEWKnQSX/tNXxlNKbQV DY4wA+e8pEQpBwBTkRtSePGWPORuHh2+c4zDi2/xeEHgV5KIU7WxEW7JXzOqpdhFMdnK YazSLkzX7dIjviEUlWshPhbysCD8WOYv2IBvG4oqqtE4pH2OlNIf7fhKvBzcL+wLxjfk jWjMDmx40X4aiNrHcDd4YD/C918kTacBlCZb/06AQ+s7jdN+kZQcGxKmFP3WtqZRM/tf PZjyqVwWuY8yllxAB2IlICxr7KZKyqLtYeUzDPbjMDU863JW3NlKJNFdw1CYKvzQH0BV FltQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=XELTIfoGMnQuDAH1yXy2k5tsqfxDgR0hQ7p0gXUqodQ=; b=Mbn6t3yV4BOOPQRgbXNyx/r1UzexmPTbKEWNly5sCjLp8jLUXCo+idCJeqqGaoHWYh ZX3AMyBtCz/TJ6TpI347IKnqVNKztvGFzBJOjdKle4n3hBpxxwQalFV5/3mWK8ZHDbgx N5FU8ufY2Ohgvu3hoZY8v8bHOd/YxZyYM3xv7oVFB9RDYqjs0lJtjj8/TqwMWowRavWZ gI83/bvGLbEO9WkgFskWdI+NwRQyjzsouHEpQquQdZKDxZ/TtkOxsTX3BK+Y7gV7WVSC egW3n3qYkzgaMLYGxMvsS880Sqppq8UuPuyCoO0NxZsoW1Rbzq/VCTp16nnLPoBcXwU1 gbHQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id z4si810377lfh.1.2021.02.08.08.16.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Feb 2021 08:16:41 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 118GGe1f018207 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Feb 2021 17:16:41 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.42.244]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 118GGeAS000994; Mon, 8 Feb 2021 17:16:40 +0100 Date: Mon, 8 Feb 2021 17:16:39 +0100 From: Henning Schild To: Anton Mikanovich Cc: Jan Kiszka , isar-users Subject: Re: [PATCH 1/3] dpkg: adjust task order to allow using "git" for patching Message-ID: <20210208171639.20b583fb@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20210122084241.10573-1-henning.schild@siemens.com> <20210122084241.10573-2-henning.schild@siemens.com> <2a620d4e-3b5d-65fa-5af5-cd656c448e6b@siemens.com> <20210122144046.363d033a@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: U5h8GHEqvOwE Am Mon, 8 Feb 2021 19:06:56 +0300 schrieb Anton Mikanovich : > 22.01.2021 16:40, Henning Schild wrote: > > Am Fri, 22 Jan 2021 11:53:58 +0100 > > schrieb Jan Kiszka : > > > >> On 22.01.21 09:42, [ext] Henning Schild wrote: > >>> From: Henning Schild > >>> > >>> The adjust_git task breaks the git tree for use outside the > >>> buildchroot. And our patch implementation supports using "git am" > >>> when setting PATCHTOOL = "git". In order to actually apply git > >>> patches we have to adjust after patching. > >> That will likely not work as is when rerunning the job for a > >> partial rebuild, e.g. after adding a patch and not changing the > >> git URL. We now need a "restore_git" prior to patch, no? > > I was also afraid of that. So i tried modifying a patch, which > > triggerd a new fetch/unpack cycle and was fine. I guess adding a > > patch will do the same. > > Changing the patch function would become problematic, but that is a > > task for isar developers. > > > > So i am almost certain that will not cause fun on partial rebuilds. > > > > Henning > > > If you've already tested partial rebuild and there is no issues can > we proceed with apply? I think so. In fact just backported this to a layer where at again performed as expected. Henning