Re: [PATCH 1/2] feat: package linux-perf-<version> in kernel recipe

[Baurzhan Ismagulov <ibr@radix50.net>]

On Thu, Jan 21, 2021 at 11:52:23AM +0100, Felix Moessbauer wrote:
> diff --git a/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile b/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile
...
> +%:
> +	CFLAGS= LDFLAGS= dh $@ --parallel
> +

> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
...
> +    d.appendVar('KBUILD_DEPENDS', d.getVar('PERF_BUILD_DEPENDS'))
> +}
> +


Extra newlines.


> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
...
> +PERF_BUILD_DEPENDS = "\
> +   asciidoctor <!stage1 !nodoc !pkg.linux.notools !nopython>, \

Inconsistent indentation, suggest 4 spaces.


> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
...
> +python() {
> +    if d.getVar('KERNEL_PACKAGE_PERF') != '1':
> +      return
> +    try:
> +      kvers = d.getVar('PV', True).split('.')
> +    except:
> +      bb.warn('could not extract kernel version. Disabling perf support. Version provided: {}'.format(d.getVar('PV', True)))
> +      d.setVar('KERNEL_PACKAGE_PERF', '0')
> +      return

I agree that we should at least try upstreaming the missing stuff. Also, does
anything speak against building it as is (possibly breaking the build)?


With kind regards,
Baurzhan.