From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6919450737082630144 X-Received: by 2002:a5d:4903:: with SMTP id x3mr24098497wrq.95.1613557715366; Wed, 17 Feb 2021 02:28:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:60c2:: with SMTP id u185ls642469wmb.2.gmail; Wed, 17 Feb 2021 02:28:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW3OK48rmpRZoi1wT1c23e0FNvifUxQCnSJxKr6UNz8pfuzwP1v299mdIVuya+28ux2+VT X-Received: by 2002:a1c:e905:: with SMTP id q5mr6601637wmc.84.1613557714580; Wed, 17 Feb 2021 02:28:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613557714; cv=none; d=google.com; s=arc-20160816; b=JSG15V6OaW6u0F9kuZ9TBDOR885f2NOFL5sMC5aRvNRasXr+oWbKPysp5cwMkytVxf NE/TsKRrGhIhSQE7zZVf4t9kXfMbEJsfkqSu3pH1qjhkOk+uTI/wx8IsAJEW+YMDAdoC 7HDadIDx/4JodUX8tvCpcHadayWIYwuuHi1hEw8rCrkSOLv2+wvJ1mNqvVYMKQWrftne nqaOu+DBK39ThbjGDXP4hy6/h7k8fHUSExBgxMAWhoWQ87+h4moz8pgeorADGswXnYJy +jdMWhCf7AyYZ19xYIMkFdUUGd9bY7fCqNPvGMPxV78Lp8l8HXSNyLYMp2FZBzCPNRXC uSqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=mdjT43KCrbQvlmBTm5zKCHiXFSYsnCeNtcpRB7mnwbk=; b=JIo+yFEzuQUzarhT1Z/6ZIEbNLh3BQysQyZJmjeTbFJA8PdoLmxuKtmINjebjFzxdq iv7H/sC1vK2HFLr9bAun/9CxEQmQ3AVtarfV2MOYk7xEwbhmqh9igLmIPeNNS4Ac8mNo jLPqc+Smf2PU87BJ1lCV8WNX/0YLepeI+iSWDSRg2+1aPTqiEqj5C/Zj0novlU6dGT0J fWqlYB1uMfbMNRnLIh0MHrA1B8Yg0B7oR/U5ECK7wI5ZxWLK+Z8g0+sQPh3r1xvT74cI aHu3++XBkMCWjD5f0Jg6fWey9TjEZBJJ+oRIelQk+M1EMCUvNMrxsGyK6NGNq7yyn9fD tzIw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id t25si65196wmj.0.2021.02.17.02.28.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Feb 2021 02:28:34 -0800 (PST) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 11HASVsO012443 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Feb 2021 11:28:33 +0100 Date: Wed, 17 Feb 2021 11:28:31 +0100 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 1/2] feat: package linux-perf- in kernel recipe Message-ID: <20210217102830.GB20742@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20210121105224.26285-2-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121105224.26285-2-felix.moessbauer@siemens.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: zbXK0Jy4zXvK On Thu, Jan 21, 2021 at 11:52:23AM +0100, Felix Moessbauer wrote: > diff --git a/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile b/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile ... > +%: > + CFLAGS= LDFLAGS= dh $@ --parallel > + > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc ... > + d.appendVar('KBUILD_DEPENDS', d.getVar('PERF_BUILD_DEPENDS')) > +} > + Extra newlines. > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc ... > +PERF_BUILD_DEPENDS = "\ > + asciidoctor , \ Inconsistent indentation, suggest 4 spaces. > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc ... > +python() { > + if d.getVar('KERNEL_PACKAGE_PERF') != '1': > + return > + try: > + kvers = d.getVar('PV', True).split('.') > + except: > + bb.warn('could not extract kernel version. Disabling perf support. Version provided: {}'.format(d.getVar('PV', True))) > + d.setVar('KERNEL_PACKAGE_PERF', '0') > + return I agree that we should at least try upstreaming the missing stuff. Also, does anything speak against building it as is (possibly breaking the build)? With kind regards, Baurzhan.