From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6932823963683782656 X-Received: by 2002:a17:907:7691:: with SMTP id jv17mr32332299ejc.75.1614199372543; Wed, 24 Feb 2021 12:42:52 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:a1d6:: with SMTP id bx22ls1598689ejb.2.gmail; Wed, 24 Feb 2021 12:42:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaT0pSiGt/hvQPbE4HrFd6f+ijmVz0ZGzRkvjEI7KOhGhYWJlb3/xvVJjSEvEsbhoZZFZR X-Received: by 2002:a17:906:6047:: with SMTP id p7mr8581979ejj.400.1614199371732; Wed, 24 Feb 2021 12:42:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614199371; cv=none; d=google.com; s=arc-20160816; b=S1EhA9mf+UdrDoWYZzu+LilaubKKmStREia0u1ulcsnHtX3MuqNjQLlmxZLL+yPcyG UEw92r+Jy4VudoqWMr8/9uwzUXFHky0P4c5yd4iNk6opHvNmfC7fZsklYNAmmrJd5OcO IWB6ItZSwhW9AD13ug5HL6GWfoCJcMTE35dGSSIUU5G131hJchrbpoYWD+ulBRx9cD8m h3ISQg/u/N6je8ytlrGBVct/Fie5cgDmr0RfIx0xSJIH46OnvNgPdgBSkjcSaT6Mg/0t GNw0t703Twa61i5Vcs2agX2lZtnDZlbdDyUV0M94WMyEi37I+aDY7U8P+vhdKXMweUMn HZJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Hevdig0NBvY8L7vKijJjZT5Oy/3i5pvAxAusXQA1Se0=; b=0QGTqMMJ29DVeIdiNS5OmBNuWfzPOLCA4il/ihQMmLNsEposAmFAop/H48Xu5oo8O0 BI+6XA4RHq2ev1TgsqJGtaG2dSRTdIorsUcFNa0LXeiFemNvaTk7HWC2nADWbCe+5NVO PFRWFDxroXWR98S+G6Y1BQ0ygYB1s0ZNEuul65Y6g/eSH9NrBzqkZEleSD85Tj11oXee obQVgg5Q+iF4BWUJ0dvykmF15B6juJGgSkuPQDYMdlSpZeUpY+5ak3+JoBX3Jjfqwt+D lLUfWl2t+zCQWAAUGmKVqAXM8t0h+jHUjYjfmrpAZ/p2Iw9WZbe0Seeix1X7jCN3TXlN NMdg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id k3si151950eds.1.2021.02.24.12.42.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2021 12:42:51 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 11OKgp0N000939 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 24 Feb 2021 21:42:51 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.35.103]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 11OKWoIc005996; Wed, 24 Feb 2021 21:32:50 +0100 Date: Wed, 24 Feb 2021 21:32:48 +0100 From: Henning Schild To: "[ext] Q. Gylstorff" Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2] sshd-regen-keys: do not enable ssh server if previously disabled Message-ID: <20210224213248.55b6ad55@md1za8fc.ad001.siemens.net> In-Reply-To: <20210224212612.430a20f8@md1za8fc.ad001.siemens.net> References: <20210224133242.30108-1-Quirin.Gylstorff@siemens.com> <20210224134145.31094-1-Quirin.Gylstorff@siemens.com> <20210224212612.430a20f8@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: n1NQzJ3zWSJv Am Wed, 24 Feb 2021 21:26:12 +0100 schrieb "[ext] Henning Schild" : > Am Wed, 24 Feb 2021 14:41:45 +0100 > schrieb "[ext] Q. Gylstorff" : > > > From: Quirin Gylstorff > > > > The code 'test -n $SSHD_ENABLED' always returns "0" and enables ssh > > even if deactivated previously. > > > > Signed-off-by: Quirin Gylstorff > > --- > > Changes V2: > > add missing space > > meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh | 2 > > +- 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh > > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh > > index 910d879..50f45eb 100644 --- > > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh +++ > > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh @@ > > -12,7 +12,7 @@ rm -v /etc/ssh/ssh_host_*_key* echo "Regenerating > > keys ..." dpkg-reconfigure openssh-server > > -if test -n $SSHD_ENABLED; then > > +if [ -n "$SSHD_ENABLED" ]; then > > Not sure i understand that. But i guess 'test -n "$SSHD_ENABLED"' > would also work, so we are looking at a quoting problem and the whole > [] is just syntactic sugar. > > Sugar i would approve, just asking. If it is all about quoting, maybe the commit message can be improved to reflect that. Henning > Henning > > > echo "Reenabling ssh server ..." > > systemctl enable --no-reload ssh > > fi >