From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6932823963683782656 X-Received: by 2002:a05:6402:22a8:: with SMTP id cx8mr1670166edb.376.1614239234066; Wed, 24 Feb 2021 23:47:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c909:: with SMTP id b9ls1020655edt.2.gmail; Wed, 24 Feb 2021 23:47:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJy94YZH/HbR6NDUubXdnvKlIMqKGzAOpx1JynkzmFiLGRJeXKiUrfZBJNYin/CxDIVwfRA+ X-Received: by 2002:a05:6402:d09:: with SMTP id eb9mr1609241edb.285.1614239233224; Wed, 24 Feb 2021 23:47:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614239233; cv=none; d=google.com; s=arc-20160816; b=0J9NV3fVpMd2xPjkApTFYaWM4D1KOlYaPeonUFN4lD0s8Hjkh3I7bI8SsHECZmRdVk x2CiyRDHM4q/ARcASXqvFGHMUepIkqg0ATPU7dIIhdRZH5RzFDVKIpJAjEKMkY+hmPLh aUssEQlJIkFw6s19g13JkpLxxTfTOXdu+NmTZBjRuApM7rGIYGS47QflMhpBYzOSJIoR jjWhhK73tof4Y7pGC0/hlBb+GVNLl1fvCiz3qckzIORAAdEZVLRL4iDbopAdFg1X8KpQ kKhJly9plm0QmrYj0mZmJG0i3Y3oTYbVlzfrxFUfNJ6UmRRGmMhPfQYDDLZYZJiGR4bi +ZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=sAl36+rtAywDebMUnMs57j9VQCZQNn2ksoulYAKpclg=; b=xyz2KkQsLgJ3zOaXFm9DBuSZOcGabekrqdLhhYbpQzlYjX+CD6pSH+DneFADt3YUiF zIJ0h956VSx9vZbmGlCd1abOW1aUBYQqfQmAlR12TDVT98P2wbsaH4XZXnTiZSWq1hFy VYvUW0+xGGoSX6DqdSeRvJ7OfUsmU1MPQ2z+lqnxawm+k+0H6X7KW/BpY52S1Dd6bKbE 4FRGKRpEWRCSb1q2veaOSxEWGAFMjA2i7T43s9llygK2m+EsWr5zb3ej4qP3IGZPOgoI IZ3zNR9mY2WyOmDvzz9tY5btg0mwFkzsyubzPuzbi3R8GeMQRCtLDHM1zz6XKXCAeicv kmXw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id k3si207761eds.1.2021.02.24.23.47.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2021 23:47:13 -0800 (PST) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 11P7lC0R031902 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 25 Feb 2021 08:47:12 +0100 Received: from md2dvrtc.fritz.box ([167.87.33.36]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 11P7lCRI006473; Thu, 25 Feb 2021 08:47:12 +0100 From: "Q. Gylstorff" To: isar-users@googlegroups.com Cc: Quirin Gylstorff Subject: [PATCH v3] sshd-regen-keys: do not enable ssh server if previously disabled Date: Thu, 25 Feb 2021 08:47:12 +0100 Message-Id: <20210225074712.31768-1-Quirin.Gylstorff@siemens.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: flPoDtM85LsK From: Quirin Gylstorff The code 'test -n $SSHD_ENABLED' always returns "0" and enables ssh even if deactivated previously. Adding quotes(") to evaluate the variable content instead of variable name. Signed-off-by: Quirin Gylstorff --- Changes V2: - add missing space Changes V#: - clarify commit message meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh index 910d879..50f45eb 100644 --- a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh +++ b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh @@ -12,7 +12,7 @@ rm -v /etc/ssh/ssh_host_*_key* echo "Regenerating keys ..." dpkg-reconfigure openssh-server -if test -n $SSHD_ENABLED; then +if [ -n "$SSHD_ENABLED" ]; then echo "Reenabling ssh server ..." systemctl enable --no-reload ssh fi -- 2.20.1