From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6924371667242188800 X-Received: by 2002:a05:600c:4fd0:: with SMTP id o16mr3058826wmq.77.1614677461065; Tue, 02 Mar 2021 01:31:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:60c2:: with SMTP id u185ls1071391wmb.2.gmail; Tue, 02 Mar 2021 01:31:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwD7ndPv9ii+sb4/NlWMT3X5EOS2aeI0+x5bbXd5duOUKrGijm+1MAZFgU1P6u80QpwL/UZ X-Received: by 2002:a7b:c0c3:: with SMTP id s3mr2984182wmh.11.1614677460326; Tue, 02 Mar 2021 01:31:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614677460; cv=none; d=google.com; s=arc-20160816; b=sb21XLx9kZjIg+BCz5lRoz8rbHY67H6h7qQxSHIVX3JZSMNQASGQGrexH5Vty1qvAP r0X/U76VQM82LHPC8nmv70H1HJk70VkMsQyM3lT17L9zMa7NTI7z4jnsvRPDPNH4yEzi ywnMYJ8mLFn+B4IWkZcXTwNonR/GN5Xqd5Iuvf+5AcQ+N4PFhj0oR6VykTru5bY+le0A 2UYSsHASlOos4a9jnGYzygpYhI1HwceBPALO99qjNnUaC6i1a48smdx0LYdFA2QnmGJN vBWGRMBopPnuKpQ5ppRB5VNF9x9aUtSDTw3r7lpFdYCMe1qm0nL0vDKLk8Qu5wgKK4uV zmSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=vEXmZP08stcZ5bDLGWgt3JmGaTe6SdW336fkXC27dBk=; b=tPF0FwnmsZFQj8BAn9KyzRVdp0PVY8vSngPs4rX3cIiD4VEuzMR5C72147FPrriPng xNo2KmarBfhj/BKPAT54XvZIDXAEzuYO2K8QzAUIJp+PozNv35ffdXlkbkyIzXDpNCE8 5prRw/oEMyzgKBCmiRtHdWifrSxPpoYDV8oEkz0aBtUk0krSo7a6Az+PvjT+lUH95cEJ TeROE6E7OTZt7NFTZpBA7hwdUe3vzGAeepPDe7un1XOQX5eRVH+gc8WYqSX0lwlZH/fi pNH5v4mGRXEPr1mzyqhmZ/qUvDqEs7CNcUbYOic6HdUnx6u/lGClmMQYMVmK6ngizTsj vgUQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id b6si133739wmc.2.2021.03.02.01.31.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Mar 2021 01:31:00 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1229UxDX019433 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Mar 2021 10:31:00 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.44.113]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1229KxMn021381; Tue, 2 Mar 2021 10:20:59 +0100 Date: Tue, 2 Mar 2021 10:20:58 +0100 From: Henning Schild To: Florian Bezdeka Cc: , , Subject: Re: [PATCH] wic: Warn if an ext filesystem affected by the Y2038 problem is used Message-ID: <20210302102058.4acf2774@md1za8fc.ad001.siemens.net> In-Reply-To: <20210301151823.64574-1-florian.bezdeka@siemens.com> References: <20210217115643.GD20742@yssyq.m.ilbers.de> <20210301151823.64574-1-florian.bezdeka@siemens.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 4fd/MHSIbCZi We usually try to not backport but bump the whole bitbake. There have been exceptions, but usually because maintainer did not enforce that, not because commits have been "super important". While this one looks good, i would say it does not justify such forking and will need to wait for the next bitbake version bump. But feel free to bump all of bitbake, might be smooth or a significant amount of work. Henning Am Mon, 1 Mar 2021 16:18:23 +0100 schrieb Florian Bezdeka : > This is the backport for upstream (openembedded-core) > eecbe6255584 ("wic: Warn if an ext filesystem affected by the Y2038 > problem is used") > > We are getting closer and closer to the year 2038 where the 32 bit > time_t overflow will happen. While products (= embedded systems) with > an expected life time of 15 years are still save the situation may > change if your system has to survive the next 20 years. > > ext2 and ext3 filesystems are always affected by the time overflow, so > let's warn the user if these filesystems are still being used. > > If ext4 is affected depends on the inode size chosen during filesystem > creation. At least 256 bytes are necessary to be safe. As ext4 is > used very often (and partitions may be created small first and > extended later) this might be an issue for many users. > > Signed-off-by: Florian Bezdeka > --- > scripts/lib/wic/misc.py | 1 + > scripts/lib/wic/partition.py | 15 +++++++-------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/scripts/lib/wic/misc.py b/scripts/lib/wic/misc.py > index 4b08d64..c4332d5 100644 > --- a/scripts/lib/wic/misc.py > +++ b/scripts/lib/wic/misc.py > @@ -26,6 +26,7 @@ logger = logging.getLogger('wic') > > # executable -> recipe pairs for exec_native_cmd > NATIVE_RECIPES = {"bmaptool": "bmap-tools", > + "dumpe2fs": "e2fsprogs", > "grub-mkimage": "grub-efi", > "isohybrid": "syslinux", > "mcopy": "mtools", > diff --git a/scripts/lib/wic/partition.py > b/scripts/lib/wic/partition.py index 4a5a31e..e6bcc9e 100644 > --- a/scripts/lib/wic/partition.py > +++ b/scripts/lib/wic/partition.py > @@ -432,26 +432,25 @@ class Partition(): > if part.mountpoint: > args = [part.fstype, "mounted at %s" % > part.mountpoint] elif part.label: > - args = [part.fstype, "labeled %s" % part.label] > + args = [part.fstype, "labeled '%s'" % part.label] > elif part.part_name: > - args = [part.fstype, "in partition %s" % > part.part_name] > + args = [part.fstype, "in partition '%s'" % > part.part_name] else: > - args = [part.fstype, ""] > + args = [part.fstype, "in partition %s" % part.num] > return err.format(*args) > > - ret, out = exec_native_cmd("dumpe2fs %s" % rootfs, > native_sysroot) - > # ext2 and ext3 are always affected by the Y2038 problem > if self.fstype in ["ext2", "ext3"]: > logger.warn(get_err_str(self)) > return > > + ret, out = exec_native_cmd("dumpe2fs %s" % rootfs, > native_sysroot) + > # if ext4 is affected by the Y2038 problem depends on the > inode size > - # Remember: inode size depends on the file system size > for line in out.splitlines(): > if line.startswith("Inode size:"): > size = int(line.split(":")[1].strip()) > if size < 256: > - logger.warn("%s Inodes (of size %d) are too > small." % \ > + logger.warn("%s Inodes (of size %d) are too > small." % (get_err_str(self), size)) > - break > \ No newline at end of file > + break