From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6932823963683782656 X-Received: by 2002:a05:6512:3226:: with SMTP id f6mr11483370lfe.171.1614680329480; Tue, 02 Mar 2021 02:18:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ac46:: with SMTP id r6ls7692924lfc.2.gmail; Tue, 02 Mar 2021 02:18:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOyKtDeJ0vWeGKhqd+/ucCpxBCtrgc9PrPTvyh/7+potxQRK8BdSlX0R4+TlaeutN3ayiB X-Received: by 2002:a05:6512:2191:: with SMTP id b17mr11865274lft.267.1614680328476; Tue, 02 Mar 2021 02:18:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614680328; cv=none; d=google.com; s=arc-20160816; b=ZVgEabq6GtLMjzbcAY9pHI9RYY/v1csYTTdYvel5n1nt/psfH6l8kmKuyjQp4ERZqQ 7ixc6X2qe7vhWpNzBNeIhR6E3rhs1us8c/PH37vhy5vXEzLsgN/VJNahq9ZGMH17AQjr 6BvC03G4pju3CGimUbJBY3NJ8MEXa2hZm0ivfYo/sZP+pC6Ldc5cpdoR1D2H8oZTfAKt 3LuNgYkVehYVMj+X0Tm6k/8bQCB/eGjqTMHDlklkKE8kVyOSX/Zs1Tnqsiy0jFjsDXov abOBKKXz4q5XWFilBOc397x4WfjHr5L4SKkcgscXZZ5RM0zMOym1HC3BoPzFDItcZ4BS aucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=+Yw9Tc1XDIoTuPGVPhPCdmezsul9wtMN1LlpzQUCu0Y=; b=z91Tl9N8pnor1ioCshq7ZyTPVFzwU9BAuVo3ZvRpaVm2OlQUfy7C6a+y1+vECzEYY7 S0bAkHJptHYRd5EzsR8pKxbNm0lmPRQTu6ebhYblZXMGn1yGYckw0OT5wNigTBm0LAtb UUfYOJBNU4HrUoeWbgaTEkXJNKYT3bwKA8xQX7+JsEoXhfx7igQp4JsukDT4Vptc0dNg /xsXnRDvrvx5m/6R7NHcqvy6/Vxb3bT3V+nj2oPDhQ5YO7T3V7+yq/gvKU5jDZSdCamD 2b/Hcd2DX6hHgMox1rJcqnfdrLSs2O2IOgz0bQ03FsA7el95NV4iLINSVWr1a3Qit/lE StLQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id b27si667302ljf.6.2021.03.02.02.18.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Mar 2021 02:18:48 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 122AIlbm019534 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 2 Mar 2021 11:18:47 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.44.113]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 122A3kwN018736; Tue, 2 Mar 2021 11:03:47 +0100 Date: Tue, 2 Mar 2021 11:03:46 +0100 From: Henning Schild To: "[ext] Q. Gylstorff" Cc: isar-users@googlegroups.com Subject: Re: [PATCH v3] sshd-regen-keys: do not enable ssh server if previously disabled Message-ID: <20210302110346.67a7b62f@md1za8fc.ad001.siemens.net> In-Reply-To: <20210225074712.31768-1-Quirin.Gylstorff@siemens.com> References: <20210225074712.31768-1-Quirin.Gylstorff@siemens.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: a+ZK7vuIg23r LGTM, i am always a fan of bumping package versions but that is often not done. You might want to do that here, but i do not feel strong about it. Henning Am Thu, 25 Feb 2021 08:47:12 +0100 schrieb "[ext] Q. Gylstorff" : > From: Quirin Gylstorff > > The code 'test -n $SSHD_ENABLED' always returns "0" and enables ssh > even if deactivated previously. Adding quotes(") to evaluate the > variable content instead of variable name. > > Signed-off-by: Quirin Gylstorff > --- > Changes V2: > - add missing space > Changes V#: > - clarify commit message > meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh index > 910d879..50f45eb 100644 --- > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh +++ > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh @@ > -12,7 +12,7 @@ rm -v /etc/ssh/ssh_host_*_key* echo "Regenerating keys > ..." dpkg-reconfigure openssh-server > -if test -n $SSHD_ENABLED; then > +if [ -n "$SSHD_ENABLED" ]; then > echo "Reenabling ssh server ..." > systemctl enable --no-reload ssh > fi