From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCH v7 4/5] docs: document creation of container images
Date: Fri, 19 Mar 2021 17:11:22 +0100 [thread overview]
Message-ID: <20210319161122.GE28779@yssyq.m.ilbers.de> (raw)
In-Reply-To: <20210312195843.96000-5-silvano.cirujano-cuesta@siemens.com>
On Fri, Mar 12, 2021 at 08:58:42PM +0100, Silvano Cirujano Cuesta wrote:
> --- a/doc/user_manual.md
...
> @@ -223,6 +227,54 @@ qemu-system-x86_64 -m 256M -nographic -bios edk2/Build/OvmfX64/RELEASE_*/FV/OVMF
...
> +### Generate container image with root-filesystem
...
> +A container image created from an ISAR configuration meant for bare-metal or virtual machines can be helpfull to test certain applications which requirements (e.g. libraries) can be easily resolved in a containerized environment.
...
> +It's technically possible, but requires making host resources (e.g. the Docker Daemon socket) accessible in the container.
> +What can endanger the stability and security of the host.
Thanks for implementing this long-standing feature, the series looks good to
me.
I'd suggest a couple of cosmetic changes:
* "root-filesystem" -> "root filesystem"
* "ISAR" -> "Isar"
* "container. What can endanger" -> "container, which can endanger"
* Wrap at column 79.
What do you think? Would it be ok to do that when we apply it, or should I send
an updated patch?
We'll play a bit with the images, but I'm quite positive we'll be able to merge
this soon.
With kind regards,
Baurzhan.
next prev parent reply other threads:[~2021-03-19 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 19:58 [PATCH v7 0/5] Add support for containerized root filesystems Silvano Cirujano Cuesta
2021-03-12 19:58 ` [PATCH v7 1/5] classes: add root filesystem containerizing class Silvano Cirujano Cuesta
2021-03-12 19:58 ` [PATCH v7 2/5] classes: add new image type 'container-img' Silvano Cirujano Cuesta
2021-03-12 19:58 ` [PATCH v7 3/5] sdk: add support for containerized sdk Silvano Cirujano Cuesta
2021-03-12 19:58 ` [PATCH v7 4/5] docs: document creation of container images Silvano Cirujano Cuesta
2021-03-19 16:11 ` Baurzhan Ismagulov [this message]
2021-03-22 12:48 ` Silvano Cirujano Cuesta
2021-03-26 12:17 ` Silvano Cirujano Cuesta
2021-03-12 19:58 ` [PATCH v7 5/5] ci: add container image sample configurations Silvano Cirujano Cuesta
2021-03-22 12:59 ` Anton Mikanovich
2021-03-22 13:11 ` Silvano Cirujano Cuesta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319161122.GE28779@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox