From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCH] dpkg: Make mount buildroot reliable
Date: Thu, 8 Apr 2021 10:13:41 +0200 [thread overview]
Message-ID: <20210408081341.GI5391@yssyq.m.ilbers.de> (raw)
In-Reply-To: <82deddfc-687d-1627-37f9-c3c0eae82505@siemens.com>
On Thu, Apr 08, 2021 at 08:27:29AM +0200, Jan Kiszka wrote:
> On 02.04.21 15:03, Anton Mikanovich wrote:
> > We use mounting for several tasks. Mounting and unmounting is performed
> > in shell scripts. If a command fails before unmounting, the directories
> > remain mounted.
>
> Right - but what is the problem to be solved? We are cleaning up in
> build_completed() whatever is left by individual jobs.
>
> I'm not against this refactoring, but the purpose should be made clearer.
This case is related to the dpkg unmounting WORKDIR and hanging forever with
"Couldn't unmount, retrying..."; it doesn't reach build_completed(). We'll
rework the commit message.
That said, the next patch addresses the hanging mounts issue by unmounting the
directories as soon as possible, so that build_completed() in most cases
doesn't have to do anything.
With kind regards,
Baurzhan.
prev parent reply other threads:[~2021-04-08 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 13:03 Anton Mikanovich
2021-04-08 6:27 ` Jan Kiszka
2021-04-08 8:13 ` Baurzhan Ismagulov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408081341.GI5391@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox