Re: [bitbake-devel] [PATCH] fetch/git: add support for disabling shared clones on unpack

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 13 Apr 2021 11:23:00 +0100
schrieb Richard Purdie <richard.purdie@linuxfoundation.org>:

> Hi,
> 
> On Mon, 2021-04-12 at 17:05 +0200, Henning Schild wrote:
> > this is still pretty much relevant to Isar, where an unpack with git
> > goes into a chroot. Having a way not clone "shared" would really
> > help us in Isar.
> > 
> > Any comments? Except for this one maybe not applying anymore, did
> > not try.  
> 
> I'm torn on this, I can see the use case but it isn't one we've
> typically run into. I can see how it is Isar specific.
> 
> I'm hesitant as the more "forks" in codepath we add to the fetcher,
> the harder it becomes to test and maintain.

That is clear, but thanks for considering Isar even though it is not
the biggest user of bitbake.

> Would you be able to add some tests for this to the testsuite 
> (bitbake-selftest)? If we have some tests we could probably add
> something.

Sure thing, if that increases the chance of a merge.

> I did also wonder whether this should be a per url parmeter or a
> global fetcher behaviour option? You'd end up adding this to all urls
> in your usecase?

That is a good point, yes we would be forced to set that per url. I
think i will go for 
  d.getVar("BB_GIT_NOSHARE") == "1"
in v2. A variable isar can set in its bitbake.conf.

Thanks,
Henning

> 
> Cheers,
> 
> Richard
> 
>