From: Henning Schild <henning.schild@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] ci: Update kas image
Date: Wed, 28 Apr 2021 18:43:00 +0200 [thread overview]
Message-ID: <20210428184300.56d2de7c@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <ce31ec69-9555-9d80-1552-df90d4505654@siemens.com>
Am Wed, 28 Apr 2021 13:54:36 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> On 27.04.21 18:48, Henning Schild wrote:
> > Am Mon, 19 Apr 2021 22:50:11 +0200
> > schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> >
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> The project moved to github's container registry, so we were
> >> pulling stale images for a while.
> >>
> >> This update also unbreaks building latest container images with
> >> Isar which was cause by missing packages in older kas-isar.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> .gitlab-ci.yml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index 1437bd7..7fc1612 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -1,4 +1,4 @@
> >> -image: kasproject/kas-isar:latest
> >> +image: ghcr.io/siemens/kas/kas-isar:latest
> >
> > Not sure about "latest", docker does not have version tracking and
> > that might be true for CI runners as well. On the other hand a
> > number needs to be tracked manually.
> >
>
> For the time being, we need latest as there is no kas-isar release
> with the container tools included yet.
I do not feel strong about it, but creating such a release would be in
your hands and possible if you feel my comment makes sense.
Henning
> Jan
>
> > Otherwise, LGTM, please follow up and merge ASAP.
> >
> > regards,
> > Henning
> >
> >> variables:
> >> GIT_STRATEGY: clone
> >
>
>
next prev parent reply other threads:[~2021-04-28 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 20:50 Jan Kiszka
2021-04-27 16:48 ` Henning Schild
2021-04-28 11:54 ` Jan Kiszka
2021-04-28 16:43 ` Henning Schild [this message]
2021-04-28 11:16 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428184300.56d2de7c@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox