From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6969105759827132416 X-Received: by 2002:a19:441a:: with SMTP id r26mr22376495lfa.104.1622621434239; Wed, 02 Jun 2021 01:10:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3b0e:: with SMTP id f14ls56lfv.3.gmail; Wed, 02 Jun 2021 01:10:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzstCHMHME1EprK3rN+Ci+rJ67hy0i0p+oumiZJyJ+Kl0qOkAeYwXQxrxmZZofE/pjfsLaw X-Received: by 2002:a19:f703:: with SMTP id z3mr11698726lfe.61.1622621432855; Wed, 02 Jun 2021 01:10:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622621432; cv=none; d=google.com; s=arc-20160816; b=Ig1C1+EULLiybhXfDt3uU0qZB5hq71w19WejaOSFET8LpgSswnO+7IAtIC/414vm4N TcQN/covomoyIHnIQ21Eq8z7bRV5dPtJLD0T4xlsFCDhE7Fze9lYVaGOWoHmmMJHCIPf CzvnBpvZFGfgG8Fs6jm70dYMdam5P4Jj34m+8Ln/pei6zQWh7tO/HoWgEnDXwfvScg6f mGUKUMCV5utdocMrgjcKrYjjHy5myLq8eB/fWJXNwcVw7GoH3x9g1FcnDTSCmWA3JRNF D+fFtCdqSNBxunzid41TuqqIoPW/oFrfaI5uKOh3ww6SZKJzFeQKf7ypKrce//dVSZpn Jchg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=E9+kcmsgx/2xjVd+jTSVCmaJdQwAJgiFW9+CX5pLdnc=; b=iyt0yuoSFopiVs4LHSLQDxbIcc7uxSm/rtctgvoQjfLG3yjZxIgfkIaimlpWru1U1I ZCJFs72fxDsGj50r6l0WoDVoJ3dZ2d7OreiG1xAnjd5TcyQ9fyCN0pFgTbQ7d08auLe2 vhy6UbF4CBoqULC+K3MDMO6h6rgTEh/uR0teAWxGaVGo8Vq2n3u+l0Y2zsWuFEsHFJ2e HJ7aAiscj73yG+HVvDJq5hpbmYfwInlgRk5V+w3BhCY1/ELm2Yus0GjUvPMbXemU65wc fPYN6eFbGjbkG6/S9KzttKSjky34pN5jOOg4JQA4odMMQ4m7EK9cuLgtWWz9kXDlhadZ B5Fw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a1si769860ljb.5.2021.06.02.01.10.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Jun 2021 01:10:32 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-160-69-214-37.mgts.dynamic.pppoe.byfly.by [37.214.69.160] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 15289Uv7011199 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Jun 2021 10:10:28 +0200 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v8 07/17] vm_boot_test: Improve QEMU images checking Date: Wed, 2 Jun 2021 11:09:11 +0300 Message-Id: <20210602080922.16435-8-amikan@ilbers.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602080922.16435-1-amikan@ilbers.de> References: <20210602080922.16435-1-amikan@ilbers.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Af8+r/g3B6xe Makes QEMU start test to analyze boot log in real-time. It helps test cases to finish as soon as booting succeeds and do not wasting time on waiting. Get rid of python-subprocess32 backport package. Signed-off-by: Anton Mikanovich --- testsuite/vm_boot_test/vm_boot_test.py | 53 ++++++++++++++++++++------ 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/testsuite/vm_boot_test/vm_boot_test.py b/testsuite/vm_boot_test/vm_boot_test.py index eee14b2..6e580d0 100644 --- a/testsuite/vm_boot_test/vm_boot_test.py +++ b/testsuite/vm_boot_test/vm_boot_test.py @@ -1,7 +1,8 @@ #!/usr/bin/env python3 import os -import subprocess32 +import select +import subprocess import sys import time import tempfile @@ -13,6 +14,9 @@ import start_vm from avocado import Test +class CanBeFinished(Exception): + pass + class VmBase(Test): def vm_start(self, arch='amd64', distro='buster'): @@ -34,18 +38,45 @@ class VmBase(Test): self.log.info('QEMU boot line: ' + str(cmdline)) - devnull = open(os.devnull, 'w') - - p1 = subprocess32.Popen(cmdline, stdout=devnull, stderr=devnull) - time.sleep(int(time_to_wait)) - p1.kill() - p1.wait() + login_prompt = b'isar login:' + service_prompt = b'Just an example' + + timeout = time.time() + int(time_to_wait) + + p1 = subprocess.Popen(cmdline, stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + try: + poller = select.poll() + poller.register(p1.stdout, select.POLLIN) + poller.register(p1.stderr, select.POLLIN) + while time.time() < timeout and p1.poll() is None: + events = poller.poll(1000 * (timeout - time.time())) + for fd, event in events: + if fd == p1.stdout.fileno(): + # Wait for the complete string if it is read in chunks + # like "i", "sar", " login:" + time.sleep(0.01) + data = os.read(fd, 1024) + if login_prompt in data: + raise CanBeFinished + if fd == p1.stderr.fileno(): + self.log.error(p1.stderr.readline()) + except CanBeFinished: + self.log.debug('Got login prompt') + finally: + if p1.poll() is None: + p1.kill() + p1.wait() if os.path.exists(output_file): - if 'isar login:' in open(output_file).read(): - return - - self.fail('Test failed') + with open(output_file, "rb") as f1: + data = f1.read() + if service_prompt in data and login_prompt in data: + return + else: + self.log.error(data) + + self.fail('Log ' + output_file) class VmBootTestFast(VmBase): -- 2.25.1