Re: [PATCH v3 0/5] Rebuild mount logic

[Henning Schild <henning.schild@siemens.com>]

This series makes things not build in containers anymore, which we
heavily rely on for CI. Exceptions in the mount logic.

I would suggest to revert and investigate.

Henning

Am Sat,  8 May 2021 09:25:13 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> Mounting is perfomed very inconsistent currently in Isar. A lot of
> mount points are left after task execution and stays mounted until
> cleanup in build_completed hook.
> 
> We already experienced issues with stuck forever on unmounting at
> "Couldn't unmount, retrying..." error.
> It is also quite easy to face with a lot of ramaining mounts after the
> failed or interrupted manual builds.
> 
> This patchset implements unmounting paths after usage. In the cases of
> mount sharing corresponding request counting is performed, so real
> mount will be done only at first request, real unmount will be done
> only after the last task will try to unmount the path.
> 
> Meantime build_completed will use emergency only, so following warning
> added to show something goes wrong.
> 
> ---
> Changes since v2:
> - Prevent race conditions.
> - Fix building qemuarm64-stretch.
> - Minimize locks.
> - Cleanup counter files.
> - Unmount /proc/sys/fs/binfmt_misc also.
> Changes since v1:
> - Make all mounts be unmounted after use.
> - Warn about lost mounts after finish.
> 
> Anton Mikanovich (5):
>   dpkg: Make mount buildroot reliable
>   buildchroot: Unmount buildchroot mounts if not needed
>   rootfs: Unmount rootfs mounts if not needed
>   wic: Unmount dirs after usage
>   events: Warn if mounted paths left
> 
>  meta/classes/buildchroot.bbclass              |  47 +++++++
>  meta/classes/dpkg-base.bbclass                | 127
> +++++++++++------- meta/classes/dpkg-gbp.bbclass                 |
> 8 +- meta/classes/dpkg.bbclass                     |  14 +-
>  meta/classes/ext4-img.bbclass                 |   2 +
>  meta/classes/fit-img.bbclass                  |   2 +
>  meta/classes/image-tools-extension.bbclass    |   2 +
>  meta/classes/image.bbclass                    |  24 ++--
>  meta/classes/initramfs.bbclass                |   2 +
>  meta/classes/isar-events.bbclass              |   1 +
>  meta/classes/rootfs.bbclass                   |  62 ++++++++-
>  meta/classes/ubi-img.bbclass                  |   2 +
>  meta/classes/ubifs-img.bbclass                |   2 +
>  meta/classes/wic-img.bbclass                  |  10 ++
>  .../buildchroot/buildchroot.inc               |   8 ++
>  15 files changed, 232 insertions(+), 81 deletions(-)
>