From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6959801776553852928 X-Received: by 2002:a0c:c68d:: with SMTP id d13mr21917137qvj.60.1623139361987; Tue, 08 Jun 2021 01:02:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ae9:ea15:: with SMTP id f21ls10058628qkg.7.gmail; Tue, 08 Jun 2021 01:02:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1xMYiN1QIYo3J10mXkZ2sca7Aa/dF0iq2z+zE/VkFTQ8u0G4tJx07f6hamhQmrwJlJP4z X-Received: by 2002:a05:620a:13a5:: with SMTP id m5mr20270312qki.119.1623139361587; Tue, 08 Jun 2021 01:02:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623139361; cv=none; d=google.com; s=arc-20160816; b=TMwNU9pZjuiLtlKaskXJ7J/N5GzQdPPRSNCj2Yq6Ci/O7XbEySnN1V2TDJdUaTqHqz gE3/NaoT5NuZC02x/bP9gz0HYnu5G7mtvb+SbsJ3iCAbItSwAixwVn76v0IUZmX58jCi P2NI/S3orcH1aRcLwUWa0A8DbMmcpa59iuV0NaPxw9JkO6Rlza4IZ3cHlFpDFDNEHHrM LVX7sr/H8FhPkBEnaqLRdhUjWizkYDt3wlcjOkqtSrW6wI5fskBy1kedxFn83gx+LTRl CMkOEyRT1hlFfzkCGAJN3z3wLNkb1Gk0b274vDz7Sd2aw/g+Q7rECkHTMNZn9jUpKvsZ 6YbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=MR6Bt7qBLgcMc340XbsUM5BKee0+mAjbF9KjhpuEb6U=; b=eEHpLqs4N+zmR2oKgyuxhbRdQqsB5KOmMa74NYPtm/3REJsqFNd3xx/DCJNUTwfOSj a0U84x6X6k18j5XZiBPLF2uXG6Pasj5jDbrZOTBbxLNXTBH9VarwrUoi+KcUjFvoNhUd lkWDiDzNSzO/vxamcnTpnwlLqqXotJgvw434NWI89dZ1IWjSpefL90e6o8IxMGFDOFRt y/+dUUptagPjVZA/i/Y7Sb0UWfzbjMz4FvOcYFgovKgbX8SKfsyQ27RQDBEnB3293an0 r9WwfxYGcrkIaBH80j/8oX65xKDoVGFrayVtO45U39LtFOeRr2mjGnZDSqnXuUM1AZhV qg2A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id y24si1600108qtm.0.2021.06.08.01.02.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Jun 2021 01:02:41 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 15882dZ3031912 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Jun 2021 10:02:39 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.38.117]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1587wYJc026410; Tue, 8 Jun 2021 09:58:34 +0200 Date: Tue, 8 Jun 2021 09:58:32 +0200 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v3 0/5] Rebuild mount logic Message-ID: <20210608095832.0f25116c@md1za8fc.ad001.siemens.net> In-Reply-To: <20210508062518.83852-1-amikan@ilbers.de> References: <20210508062518.83852-1-amikan@ilbers.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: L/BqM3C0ity1 This series makes things not build in containers anymore, which we heavily rely on for CI. Exceptions in the mount logic. I would suggest to revert and investigate. Henning Am Sat, 8 May 2021 09:25:13 +0300 schrieb Anton Mikanovich : > Mounting is perfomed very inconsistent currently in Isar. A lot of > mount points are left after task execution and stays mounted until > cleanup in build_completed hook. > > We already experienced issues with stuck forever on unmounting at > "Couldn't unmount, retrying..." error. > It is also quite easy to face with a lot of ramaining mounts after the > failed or interrupted manual builds. > > This patchset implements unmounting paths after usage. In the cases of > mount sharing corresponding request counting is performed, so real > mount will be done only at first request, real unmount will be done > only after the last task will try to unmount the path. > > Meantime build_completed will use emergency only, so following warning > added to show something goes wrong. > > --- > Changes since v2: > - Prevent race conditions. > - Fix building qemuarm64-stretch. > - Minimize locks. > - Cleanup counter files. > - Unmount /proc/sys/fs/binfmt_misc also. > Changes since v1: > - Make all mounts be unmounted after use. > - Warn about lost mounts after finish. > > Anton Mikanovich (5): > dpkg: Make mount buildroot reliable > buildchroot: Unmount buildchroot mounts if not needed > rootfs: Unmount rootfs mounts if not needed > wic: Unmount dirs after usage > events: Warn if mounted paths left > > meta/classes/buildchroot.bbclass | 47 +++++++ > meta/classes/dpkg-base.bbclass | 127 > +++++++++++------- meta/classes/dpkg-gbp.bbclass | > 8 +- meta/classes/dpkg.bbclass | 14 +- > meta/classes/ext4-img.bbclass | 2 + > meta/classes/fit-img.bbclass | 2 + > meta/classes/image-tools-extension.bbclass | 2 + > meta/classes/image.bbclass | 24 ++-- > meta/classes/initramfs.bbclass | 2 + > meta/classes/isar-events.bbclass | 1 + > meta/classes/rootfs.bbclass | 62 ++++++++- > meta/classes/ubi-img.bbclass | 2 + > meta/classes/ubifs-img.bbclass | 2 + > meta/classes/wic-img.bbclass | 10 ++ > .../buildchroot/buildchroot.inc | 8 ++ > 15 files changed, 232 insertions(+), 81 deletions(-) >