From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6972057154493612032 X-Received: by 2002:a17:90a:fb51:: with SMTP id iq17mr3805773pjb.26.1623337555913; Thu, 10 Jun 2021 08:05:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a65:4107:: with SMTP id w7ls3028860pgp.3.gmail; Thu, 10 Jun 2021 08:05:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdjrYPNzvn1ScOpXU5ZxuECV2tYnNDHKNUXBr/jQEGNHNl5BcMqZSdEGmb0rboe1KrHa/7 X-Received: by 2002:a63:5052:: with SMTP id q18mr5321873pgl.349.1623337555185; Thu, 10 Jun 2021 08:05:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623337555; cv=none; d=google.com; s=arc-20160816; b=Gx5oWHSOBQkx4Nvwwh/G1LbiloAcq1ztgcU+M1817URj6FvwdhWjKKYut7P8LnuUGJ KoAkHqnJEBaE/V4xdYmmbTnlvKhM/ZPH2/7gELf+2Gg+RlZcLyMdfc/CqmEHuNIyRYsj UrIED5a0iDhU7RXNEobbmBNlRK2JXk5XkPqH1md48s8HJLqMC27Tmcm0KOQNuLXcIjhW /k7aEvf5QVaiSUshDS6a9rMKMeDMEOl+/EtkyA4Z3xtRZZ56XhDrHXWEpsFK7yPY6oYA pUNX+45JY8mMdxennHra6g9UdBFifJFgW3Lu7g4qBTi6GNomulIB1PQiRwS1Zxl6e+4T ZtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Pg2Qj4/jxKyfu+TghiCR+rbkSM2jkp00VFTT9qKxfoQ=; b=Jf9+4vu2MhSUaxIzVjZ212cyJUmzhJPWNbB3AeitFFzoGDWaRdWvlYnOb11ZKpQZkw NGF0W/GkV9/Nb9LSd6QmyDSwdyVoBJ5Si8BAo1uUiThK2rrttoqGGGHMamIaBvuGRshg XlE4YqzMd7hekvzd3aMwh6kgYVjgjdUv8Lo4oDiG0p4hZLcMri80jTGjXkwVwbUizV/+ /QXYilZFpmuk5DgJ6Li5RrastWWN92WrHrO8geFqausjZpYtJO1DqOwgqoyLs0fGZ4mV q/lbeAbPtJ3syz7BYv7fqf+ftNl4qCKQpyOxEvfHAqHPY1b8VmuroA3/DI0TMMMB4yoe q+lA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id n5si366321pgf.5.2021.06.10.08.05.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jun 2021 08:05:55 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 15AF5qjK032216 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Jun 2021 17:05:52 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.8.208]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 15AF5qLM007758; Thu, 10 Jun 2021 17:05:52 +0200 Date: Thu, 10 Jun 2021 17:05:50 +0200 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH] buildchroot: Remove bashism when reading file content Message-ID: <20210610170550.4accedf0@md1za8fc.ad001.siemens.net> In-Reply-To: <20210610070222.5965-1-amikan@ilbers.de> References: <20210610070222.5965-1-amikan@ilbers.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: a4apz6SppvvZ That does fix the build issues in docker/CI. So i think it should be merged because without it people using a container workflow wont be able to use next. regards, Henning Am Thu, 10 Jun 2021 10:02:22 +0300 schrieb Anton Mikanovich : > Reading mount counter with $( the environments, so replace it with more generic POSIX way: > $(cat file) > > Signed-off-by: Anton Mikanovich > --- > meta/classes/buildchroot.bbclass | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass index 97d5301..806a29f 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -30,7 +30,7 @@ buildchroot_do_mounts() { > > count="1" > if [ -f '${BUILDCHROOT_DIR}.mount' ]; then > - count=$(($(< '${BUILDCHROOT_DIR}.mount') + 1)) > + count=$(($(cat '${BUILDCHROOT_DIR}.mount') + 1)) > fi > echo $count > '${BUILDCHROOT_DIR}.mount' > if [ $count -gt 1 ]; then > @@ -78,9 +78,10 @@ buildchroot_undo_mounts() { > set -e > > if [ -f '${BUILDCHROOT_DIR}.mount' ]; then > - count=$(($(< '${BUILDCHROOT_DIR}.mount') - 1)) > + count=$(($(cat '${BUILDCHROOT_DIR}.mount') - 1)) > echo $count > '${BUILDCHROOT_DIR}.mount' > else > + echo "Could not find mount counter" > exit 1 > fi > if [ $count -gt 0 ]; then