From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6982225001537601536 X-Received: by 2002:ac2:4a8c:: with SMTP id l12mr905288lfp.657.1626106144269; Mon, 12 Jul 2021 09:09:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:430b:: with SMTP id l11ls1304584lfh.1.gmail; Mon, 12 Jul 2021 09:09:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtNUVoRVl3LSo87a6Vy6/TNJN3pnM2XcrDw5lR7ibNxw2ga4vAgepQIKcwRoCNX4TN3b3l X-Received: by 2002:ac2:41d0:: with SMTP id d16mr39382127lfi.361.1626106143132; Mon, 12 Jul 2021 09:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626106143; cv=none; d=google.com; s=arc-20160816; b=pkydJTd923PEr577yuB9ZBnDgXGfydFk8Qhuk/r5gDASrnhMBKLQ4JuPuMOF2hZfuD VC64FjnsfS4Xoc75z8c5d/fkyKoqrYqt19vUjUPudxAeNaQFRX8xzTmDT3hHfNGBckI3 ZwBgmDvrA3+n66Ydp1CeeBT/jO94Pe7vu6ERrlsBJw5sIZZlQsJltifSHCej3XzA9mce r3gVBvGi6M59JQW2M76gDZMsmSSv5mi8fW9twr5aOYLF9x6wbbuy1ao8Dix2mG3iBQOM d00kdB3W3lJ0vhiUbDqOcy4T3Chv0ffc3NNb6OlPPvj8RyMIC85kXp+xdMNRjU+GvD/N iPZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date; bh=MmSMqo5AUkJmeKosCUdizWETfIpQsuuHbNsHTBVXIQk=; b=OrIp8LrOZTjBBBKw1l2DO0PifWJZGwdrv7Ue9OLQlq1iet5uovm/1+0W9C7E6uWYnb cvAkcVoyczLo/M1lp0J2GdHMc11Ugmw5p3lXbkEP9UMqVrAfJrb+ROQ82FnwSnPY/aCJ RwLNbQVWKDMZMTZbOth02oYRFjU/5lN2gSKB3Mbzt4sjaTcY+Jw+pyqph+nMt0iMlw1B U9lbFTOiHRsx3ibU8tbjJdZRit7J8z0DfyGQKoCr6QrDZX2PY2dOKPDDbuE/4XG9ph3H RGFZsAjIb9eni+87Z8xyPw+Bx3RQZqgsYYJYepieoWNrzBVjGirm4crHhlGjVO6HXgfS hMpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id d9si401505lji.3.2021.07.12.09.09.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jul 2021 09:09:02 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 16CG8tob024781 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jul 2021 18:09:01 +0200 Date: Mon, 12 Jul 2021 18:08:55 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Cc: Anton Mikanovich , Jan Kiszka Subject: Re: [PATCH v1 5/5] events: Unmount all lost mounts at task fail Message-ID: <20210712160855.GA18446@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com, Anton Mikanovich , Jan Kiszka References: <20210707163851.204296-1-amikan@ilbers.de> <20210707163851.204296-6-amikan@ilbers.de> <61de5d8d-08d4-9760-3467-d0313b3cb702@siemens.com> <61cdeb13-6c73-ba11-6085-81909163a477@ilbers.de> <24de0200-d23e-0fe4-9db1-d876ca6fa55a@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24de0200-d23e-0fe4-9db1-d876ca6fa55a@siemens.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: eLnuTBouFqla On Thu, Jul 08, 2021 at 06:28:38PM +0200, Jan Kiszka wrote: > >> No looping, so everything you miss here will continue to be cleaned up > >> by build_completed() - so what's the point of these changes? ... > I do get the idea of a perfect world where a single attempt to umount > works and cleanly pairs with the regular umount when the task succeeds. > The problem is that I cannot see that this has been validate to truly > catch the corner cases that the lazy, late-triggered scheme addresses so > far. If it does not handle that, these umounts are pointless. If it > does, we can drop the build_completed() handler. Having both indicates > no progress, just more complexity. Thanks Jan for the review and the use cases, I agree that some patches could be refined and better documented. We'll work on the topics you've raised and respond. I'm afraid we'd need your help regarding reproducing and analysis of the old issues, because in general, many issues so far have been rarely reproducible across different build hosts. With kind regards, Baurzhan.