From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6995471841453146112 X-Received: by 2002:a5d:658a:: with SMTP id q10mr3374727wru.343.1628862934463; Fri, 13 Aug 2021 06:55:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cb09:: with SMTP id u9ls856979wmj.1.gmail; Fri, 13 Aug 2021 06:55:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4Qig1plHrOx4O18HDKJ5f0VKinH93Oa+OLUiCcxX+NqpowBn5Zl6N+v8CEbo0fBgeUvQT X-Received: by 2002:a5d:6691:: with SMTP id l17mr3319253wru.368.1628862933522; Fri, 13 Aug 2021 06:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628862933; cv=none; d=google.com; s=arc-20160816; b=ifEN3fZro8gvwuzei5K1Z7w7NWddt6KX++CNXg456tKc0uf9VjCVMgn2hFki7RsAym CIl+4+8jPVD2/5F4V8IqQvLtMxsj+2aI+doh1+Ewl5y72utY7P4vHCNevXLRpfVHyce5 W11BiGECbEtCL7RaicY1C3PL0KLRh3ALdMOXIwsUZtX7oovTrTiKoNj3VdaRbS6T3Yc3 hYuzvYY+lLNI9XPcjpvfimSdyoGfS6PIILDiu9ku2WptUeO9A7tWohJg1sdR54YOVK/D clNK+BsZxHLLWIOUileyv7FMIYP+kuBTocM1IXlrhI3XV50iCEjpXF2f1nX+DPVdzl/V bzrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=rszZe75M781kAQXhW+To0Y0l5AUwIjTffTYI5ZB8BTc=; b=nP1M06gFq4AYLnSlX2DXqSQW+Ao7UCCJGTN59NcxO5T+B86VA2yGI8TS9wrOWuxACY x+2XOaDrCwJj6WFJ5XkkReZ8RPVzHsdY6PYG9YAn+AIb619uxQ8fVny3ZyFzNb40UZ+9 vCw79qgyHB1z83vokO5dQIziWMXpbruMfxFXhdowxcPrHK86pZJgInShTfTmYAECZCsk RY0OhGpJsVDLfluzNMeFm7b6FR11qZRDFYvELSdp19S0bdmuyRn7ck+VQFMG8gvWQfuD neZrBwPzDzpB3Y7U0D28Gl1FXZAu5WtioymIRu1b90wJ0En7dqFdPl+u6Mf8Y5pe99zw KxuQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id o124si103788wme.2.2021.08.13.06.55.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Aug 2021 06:55:33 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 17DDtWM2017427 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Aug 2021 15:55:33 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 17DDtWvI025210; Fri, 13 Aug 2021 15:55:32 +0200 Date: Fri, 13 Aug 2021 15:55:32 +0200 From: Henning Schild To: Jan Kiszka Cc: isar-users , Uladzimir Bely Subject: Re: [PATCH v2 1/4] dpkg-base: Lock do_adjust_git against each other Message-ID: <20210813155532.077d2f21@md1za8fc.ad001.siemens.net> In-Reply-To: <783379a67fd56190657de0044e28b354f3e9b1a0.1628768932.git.jan.kiszka@siemens.com> References: <783379a67fd56190657de0044e28b354f3e9b1a0.1628768932.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: v033BLwLv9ca Am Thu, 12 Aug 2021 13:48:49 +0200 schrieb Jan Kiszka : > From: Jan Kiszka > > This is needed since e47ada143469 because we now adjust the links to > mirrors in DL_DIR which may collide with other tasks doing this at the > same time. > > Locking with also be needed soon for establishing the host-side link > to the download dir. > > Signed-off-by: Jan Kiszka > --- > meta/classes/dpkg-base.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index ec8fbc1..fe16846 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -55,6 +55,7 @@ python do_adjust_git() { > } > > addtask adjust_git before do_dpkg_build > +do_adjust_git[lockfiles] += "${DL_DIR}/isar.lock" The name of the file and the location suggest pretty wide locking ... could sound like the whole DL_DIR is locked, by isar ... I know that is a "pattern" but not sure it is a good one. Maybe using the task name would be better. Henning > inherit patch > addtask patch before do_adjust_git