Re: [PATCH v4 5/5] events: Do not warn on left mounts by default

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 16 Aug 2021 18:37:56 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> Disable warnings printing for all the mount points left after build
> completed to do not flood build logs too much in case build fail.
> 
> Logging can be enabled by setting ISAR_MOUNTS_CLEANUP_DEBUG to 1.

Can we find something more generic to attach to? Something that
represents verbose logging / debug tracing in general? We can not
invent a new variable for every aspect we want to debug. Could also
just comment that out ... to have it back handy for someone having to
debug.

Henning

> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta-isar/conf/local.conf.sample | 3 +++
>  meta/classes/isar-events.bbclass | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/conf/local.conf.sample
> b/meta-isar/conf/local.conf.sample index 6cf1656..ca43261 100644
> --- a/meta-isar/conf/local.conf.sample
> +++ b/meta-isar/conf/local.conf.sample
> @@ -219,3 +219,6 @@ USER_isar[flags] = "system create-home"
>  
>  # Uncomment the below line to debug WIC.
>  # WIC_CREATE_EXTRA_ARGS += "-D"
> +
> +# Uncomment this to enable warn on all left mounts after build
> complete +#ISAR_MOUNTS_CLEANUP_DEBUG ?= "1"
> diff --git a/meta/classes/isar-events.bbclass
> b/meta/classes/isar-events.bbclass index 2f8bf6e..60bb1a9 100644
> --- a/meta/classes/isar-events.bbclass
> +++ b/meta/classes/isar-events.bbclass
> @@ -54,7 +54,8 @@ python build_completed() {
>      with open('/proc/mounts') as f:
>          for line in f.readlines():
>              if basepath in line:
> -                bb.warn('%s left mounted, unmounting...' %
> line.split()[1])
> +                if d.getVar('ISAR_MOUNTS_CLEANUP_DEBUG', True) ==
> '1':
> +                    bb.warn('%s left mounted, unmounting...' %
> line.split()[1]) subprocess.call(
>                      ["sudo", "umount", "-l", line.split()[1]],
>                      stdout=subprocess.DEVNULL,