From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a19:c201:: with SMTP id l1mr6192088lfc.306.1629129214267; Mon, 16 Aug 2021 08:53:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:b24:: with SMTP id w36ls1589544lfu.1.gmail; Mon, 16 Aug 2021 08:53:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO9w37UTke6IhEoEkxHGKd29x48CnFT67IxKzxdTB1GqKvbc2IxZ9cHKtLZNYW3x+dtgvk X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr12436097lfa.233.1629129213175; Mon, 16 Aug 2021 08:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629129213; cv=none; d=google.com; s=arc-20160816; b=FMTaEeYyskQ2Ae4x0SORdR0dUY2tRzkM71a6gg4fivEeiRguQ3Vs0UHxb5YjmaXOQh 9/pUY2U6Hc4Mm3WzjEuNfgNI1v5J2zbF0y0p6jPjUwXV0p3oTRQALvLr0RKhpL/FdYMa I/uyqvkc65qfodMBhFgQH9Bkph5bCx9KEgaiq8Z1jh0KeTK41eyLqNGZZgbY+yWBSVDK h1y7RSJwigxOcpF/PfpsV/D6PFZW9dZs2Gue53xWcxYXkCnAsOHjUGAjJ/IBxtCvreRu En8JHAZ7Cabw8VQWXmz/AGf/yqS/r6yzR0BVRPIVwlVryvHYlhBaYMJvfDLkOGORkAjq bqrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=KDbdaElU1E+vgqdjD0mgaMjhgWPOSarm5cUwSpGHkJ8=; b=YORIxTLlN0Yg+s9S23GdNubNNz9T/IMLnWgl3Km/U3U8akOZbnTTvnDu9qLJgCbYIc J1y1vHr2umS0xitLtP7gxr73h8fi2M2nbBgytEIeJ3/XwCsX2kVMfH1TSNDYTBHtXdGx JAcFzodDe7TInGEdxJrjCuwQQF8mBQ++qxYc3eUg2RxlblLhT4dFpvwuFGwvcMO6jUqw oAMvPSFIX3nSVf446cPHqTPGpz1Wgjt3j76iv5O25PomEmDAwg81KTkMMtrzPnxQL/Bt AedtC+8TlLYm5aRWMOFHLv8POA/vA7LWu1S6AwV76BCGlK0ii+VTTuSCnscwsJyZ7l88 kjFA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id v2si439362ljh.8.2021.08.16.08.53.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Aug 2021 08:53:32 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 17GFrViF004314 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Aug 2021 17:53:32 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 17GFrVLQ032451; Mon, 16 Aug 2021 17:53:31 +0200 Date: Mon, 16 Aug 2021 17:53:31 +0200 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v4 5/5] events: Do not warn on left mounts by default Message-ID: <20210816175331.2e990e44@md1za8fc.ad001.siemens.net> In-Reply-To: <20210816153756.3549038-6-amikan@ilbers.de> References: <20210816153756.3549038-1-amikan@ilbers.de> <20210816153756.3549038-6-amikan@ilbers.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: j38u5RQoh0A/ Am Mon, 16 Aug 2021 18:37:56 +0300 schrieb Anton Mikanovich : > Disable warnings printing for all the mount points left after build > completed to do not flood build logs too much in case build fail. > > Logging can be enabled by setting ISAR_MOUNTS_CLEANUP_DEBUG to 1. Can we find something more generic to attach to? Something that represents verbose logging / debug tracing in general? We can not invent a new variable for every aspect we want to debug. Could also just comment that out ... to have it back handy for someone having to debug. Henning > Signed-off-by: Anton Mikanovich > --- > meta-isar/conf/local.conf.sample | 3 +++ > meta/classes/isar-events.bbclass | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/conf/local.conf.sample > b/meta-isar/conf/local.conf.sample index 6cf1656..ca43261 100644 > --- a/meta-isar/conf/local.conf.sample > +++ b/meta-isar/conf/local.conf.sample > @@ -219,3 +219,6 @@ USER_isar[flags] = "system create-home" > > # Uncomment the below line to debug WIC. > # WIC_CREATE_EXTRA_ARGS += "-D" > + > +# Uncomment this to enable warn on all left mounts after build > complete +#ISAR_MOUNTS_CLEANUP_DEBUG ?= "1" > diff --git a/meta/classes/isar-events.bbclass > b/meta/classes/isar-events.bbclass index 2f8bf6e..60bb1a9 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -54,7 +54,8 @@ python build_completed() { > with open('/proc/mounts') as f: > for line in f.readlines(): > if basepath in line: > - bb.warn('%s left mounted, unmounting...' % > line.split()[1]) > + if d.getVar('ISAR_MOUNTS_CLEANUP_DEBUG', True) == > '1': > + bb.warn('%s left mounted, unmounting...' % > line.split()[1]) subprocess.call( > ["sudo", "umount", "-l", line.split()[1]], > stdout=subprocess.DEVNULL,