From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a1c:7304:: with SMTP id d4mr16315068wmb.119.1629130155717; Mon, 16 Aug 2021 09:09:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1994:: with SMTP id t20ls4336249wmq.2.canary-gmail; Mon, 16 Aug 2021 09:09:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMxBqy1MfwL+oTa+8N+BfEfaRXiBD5lNwBWgNqee/9ptD5hbdRr3+KNQ7lpQF+t0CQo3Uv X-Received: by 2002:a7b:c8cd:: with SMTP id f13mr16101828wml.6.1629130154607; Mon, 16 Aug 2021 09:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629130154; cv=none; d=google.com; s=arc-20160816; b=RPpeKZCxTw3T18qxI7OTGmafWxwh1+ACsi7GCn1NfvfpoLdEyVKnjHEkC841t/xBHy A1ayDfS5kggUBqbO+x9AZQX9cCnpvQIhUhTw/8FD0jHj8HNfHlDbxeQ9VMdkxd/+kVsm imkXPa8aQN2bT2DAVM8BSCGMpTUec4WCi8K308GCBIqsxgqvBUw3gtsUSxYbXnmXdbta nsMWm7AORIbyfqEnxmwu0XyuYZPmKDEJn0ZLTrXKKeggAUB+gVKCjkHR+WwlmcNs+MVq e0uwFU4NLiacY6pqbuDKygjxJv65ga5iuBOsUxuWiCE5o8ip7D/aBMkLzvY3wqxFMl2g zw4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=dHlJQj0mc+3+0jF7pDxjTmEwI8IIGJNnDcM6ykfJ404=; b=GGKSQcuUKuhqh48sGlbHWI5LjxCAVNIT9BZA+GmridXAMkzu1bbsb/PAmtFVCkABnQ wdIbiCehSlsK9Nt4I7N6FX6wAFuM4DAEvjn59kzA3QToUmGPNqGEHqt6MJE6LhrH1zTM 0BaYMHzL4mtBw60MWkifM5bfWkMfuJ4q4/vG83biHD5lNRHt8aekxnGKP/o152JFwx4Q AUgT99OyW6ZUMQea9Zgqd6Un6UQgce34GfnUgbBJJ0zqFSeSisZ5Ddnv+oDc8gJ+HqF7 Ofzc7w/tRobgnN2WjrJu1nNSw2tXEnFxJzdmRONjuqaqXMW+N8Lvj01+cE6SQoLP+Kw0 cQow== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id m33si475912wms.0.2021.08.16.09.09.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Aug 2021 09:09:14 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 17GG9ERZ013835 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Aug 2021 18:09:14 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 17GG9DDL019453; Mon, 16 Aug 2021 18:09:14 +0200 Date: Mon, 16 Aug 2021 18:09:13 +0200 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v4 2/5] dpkg: Limit unmount loop Message-ID: <20210816180913.763d84a6@md1za8fc.ad001.siemens.net> In-Reply-To: <20210816153756.3549038-3-amikan@ilbers.de> References: <20210816153756.3549038-1-amikan@ilbers.de> <20210816153756.3549038-3-amikan@ilbers.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Gfq2xMsfkXe0 Am Mon, 16 Aug 2021 18:37:53 +0300 schrieb Anton Mikanovich : > In the past, unmounting WORKDIR caused infinite looping with the > "Couldn't unmount, retrying..." warning if the first linux-mainline > task failed and the second one succeeded (it is built for > de0-nano-soc-buster and stm32mp15x-buster). > > This change limits the loop to 1000 s. > > Signed-off-by: Anton Mikanovich > --- > meta/classes/dpkg-base.bbclass | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 4b189f1..105a1e6 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -157,14 +157,16 @@ dpkg_do_mounts() { > } > > dpkg_undo_mounts() { > - i=1 > + i=0 > while ! sudo umount ${BUILDROOT}; do > sleep 0.1 > - i=`expr $i + 1` > - if [ $i -gt 100 ]; then > - bbwarn "${BUILDROOT}: Couldn't unmount, retrying..." > - i=1 > + if [ `expr $i % 100` -eq 0 ] ; then > + bbwarn "${BUILDROOT}: Couldn't unmount ($i), retrying..." > + fi > + if [ $i -gt 10000 ]; then > + bbfatal "${BUILDROOT}: Couldn't unmount after timeout" > fi > + i=`expr $i + 1` IMHO it would be easier to read how long that will take in total ... if it was "sleep 1" ... "% 10" and "-gt 1000" ... in fact i think it should be "-ge 1000" now that you start with 0. But on off-by-one in a timeout it not the biggest problem. Henning > done > sudo rmdir ${BUILDROOT} > }