public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v5 0/5] Restore downstream mounts compatibility
Date: Tue, 17 Aug 2021 15:38:03 +0300	[thread overview]
Message-ID: <20210817123808.3563834-1-amikan@ilbers.de> (raw)

Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken
compatibility with downstream projects. Move try-finally from
dpkg_runbuild(), etc. to the caller, do_dpkg_build().

Also enable reference counting for image mounts for several image tasks
running in parallel (like e.g. ubi-ubifs-img).

Tested with kas-iot2050-example project from:
https://github.com/siemens/meta-iot2050

---
Changes sinse v4:
- Fix while loop counts.
- Move unmount warnings under debug.
Changes since v3:
- Warn on first entering in umount while loop.
- Do not warn on left mounts by default.
- Remote incorrect dpkg unmount usage protection.
- Rebase on next.
- Improve commit messages.
Changes since v2:
- Remove incorrect buildchroot/rootfs mount/unmount usage protection.
- Remove task fail handler.
- Implement double mount protection by try-finally.
Changes since v1:
- Get back while loop in dpkg_undo_mounts.
- Exit dpkg_undo_mounts if already mounted.
- Do not ignore exceptions in safe_exec.

Anton Mikanovich (5):
  Revert "dpkg: Make mount buildroot reliable"
  dpkg: Limit unmount loop
  image: Add reference counter
  dpkg-base: Clean up unmounting in do_dpkg_build()
  events: Do not warn on left mounts by default

 meta/classes/dpkg-base.bbclass   | 125 +++++++++++++------------------
 meta/classes/dpkg-gbp.bbclass    |   8 +-
 meta/classes/dpkg.bbclass        |  14 +---
 meta/classes/image.bbclass       |  39 +++++++++-
 meta/classes/isar-events.bbclass |   2 +-
 5 files changed, 97 insertions(+), 91 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-08-17 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 12:38 Anton Mikanovich [this message]
2021-08-17 12:38 ` [PATCH v5 1/5] Revert "dpkg: Make mount buildroot reliable" Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 2/5] dpkg: Limit unmount loop Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 3/5] image: Add reference counter Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 4/5] dpkg-base: Clean up unmounting in do_dpkg_build() Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 5/5] events: Do not warn on left mounts by default Anton Mikanovich
2021-08-18 16:24 ` [PATCH v5 0/5] Restore downstream mounts compatibility Jan Kiszka
2021-08-18 17:39   ` Jan Kiszka
2021-08-20  8:12     ` Anton Mikanovich
2021-08-20  9:51       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817123808.3563834-1-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox