From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v5 2/5] dpkg: Limit unmount loop
Date: Tue, 17 Aug 2021 15:38:05 +0300 [thread overview]
Message-ID: <20210817123808.3563834-3-amikan@ilbers.de> (raw)
In-Reply-To: <20210817123808.3563834-1-amikan@ilbers.de>
In the past, unmounting WORKDIR caused infinite looping with the
"Couldn't unmount, retrying..." warning if the first linux-mainline task
failed and the second one succeeded (it is built for de0-nano-soc-buster
and stm32mp15x-buster).
This change limits the loop to 1000 s.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
meta/classes/dpkg-base.bbclass | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 4b189f1..46b9700 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -157,14 +157,16 @@ dpkg_do_mounts() {
}
dpkg_undo_mounts() {
- i=1
+ i=0
while ! sudo umount ${BUILDROOT}; do
sleep 0.1
- i=`expr $i + 1`
- if [ $i -gt 100 ]; then
- bbwarn "${BUILDROOT}: Couldn't unmount, retrying..."
- i=1
+ if [ `expr $i % 100` -eq 0 ] ; then
+ bbwarn "${BUILDROOT}: Couldn't unmount ($i), retrying..."
+ fi
+ if [ $i -ge 10000 ]; then
+ bbfatal "${BUILDROOT}: Couldn't unmount after timeout"
fi
+ i=`expr $i + 1`
done
sudo rmdir ${BUILDROOT}
}
--
2.25.1
next prev parent reply other threads:[~2021-08-17 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 12:38 [PATCH v5 0/5] Restore downstream mounts compatibility Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 1/5] Revert "dpkg: Make mount buildroot reliable" Anton Mikanovich
2021-08-17 12:38 ` Anton Mikanovich [this message]
2021-08-17 12:38 ` [PATCH v5 3/5] image: Add reference counter Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 4/5] dpkg-base: Clean up unmounting in do_dpkg_build() Anton Mikanovich
2021-08-17 12:38 ` [PATCH v5 5/5] events: Do not warn on left mounts by default Anton Mikanovich
2021-08-18 16:24 ` [PATCH v5 0/5] Restore downstream mounts compatibility Jan Kiszka
2021-08-18 17:39 ` Jan Kiszka
2021-08-20 8:12 ` Anton Mikanovich
2021-08-20 9:51 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817123808.3563834-3-amikan@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox