[PATCH v6 0/6] Restore downstream mounts compatibility

[Anton Mikanovich <amikan@ilbers.de>]

Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken
compatibility with downstream projects. Move try-finally from
dpkg_runbuild(), etc. to the caller, do_dpkg_build().

Also revert e438c8f62b9aacb2c9d5120e93f81637f091a83c and
3360b7d9ff85172dc3d2275c35caec71149b35ef commits to prevent 'umount:
target is busy' issues caused by /dev and /sys mounts stayed locked
even after task finish in some cases. Those two commits should be
applied back after this issue is found and fixed.

Move mounts left printing from warnings to debug output bacause
per-task unmounting was reverted.

Tested with kas-iot2050-example project from:
https://github.com/siemens/meta-iot2050

---
Changes sinse v5:
- Revert buildchroot per-task unmounts.
- Revert rootfs per-task unmounts.
- Remove imager per-task unmounts.
Changes sinse v4:
- Fix while loop counts.
- Move unmount warnings under debug.
Changes since v3:
- Warn on first entering in umount while loop.
- Do not warn on left mounts by default.
- Remote incorrect dpkg unmount usage protection.
- Rebase on next.
- Improve commit messages.
Changes since v2:
- Remove incorrect buildchroot/rootfs mount/unmount usage protection.
- Remove task fail handler.
- Implement double mount protection by try-finally.
Changes since v1:
- Get back while loop in dpkg_undo_mounts.
- Exit dpkg_undo_mounts if already mounted.
- Do not ignore exceptions in safe_exec.

Anton Mikanovich (6):
  Revert "dpkg: Make mount buildroot reliable"
  dpkg: Limit unmount loop
  dpkg-base: Clean up unmounting in do_dpkg_build()
  events: Do not warn on left mounts by default
  Revert "rootfs: Unmount rootfs mounts if not needed"
  Revert "buildchroot: Unmount buildchroot mounts if not needed"

 meta/classes/buildchroot.bbclass              |  47 -------
 meta/classes/dpkg-base.bbclass                | 123 +++++++-----------
 meta/classes/dpkg-gbp.bbclass                 |   8 +-
 meta/classes/dpkg.bbclass                     |  14 +-
 meta/classes/ext4-img.bbclass                 |   2 -
 meta/classes/fit-img.bbclass                  |   2 -
 meta/classes/image-tools-extension.bbclass    |   2 -
 meta/classes/image.bbclass                    |  24 ++--
 meta/classes/initramfs.bbclass                |   2 -
 meta/classes/isar-events.bbclass              |   2 +-
 meta/classes/rootfs.bbclass                   |  63 +--------
 meta/classes/ubi-img.bbclass                  |   2 -
 meta/classes/ubifs-img.bbclass                |   2 -
 meta/classes/wic-img.bbclass                  |   1 -
 .../buildchroot/buildchroot.inc               |   8 --
 15 files changed, 82 insertions(+), 220 deletions(-)

-- 
2.25.1