From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a2e:7103:: with SMTP id m3mr27126951ljc.122.1629714237634; Mon, 23 Aug 2021 03:23:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4146:: with SMTP id c6ls732583lfi.2.gmail; Mon, 23 Aug 2021 03:23:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOfIf++4r+wb6fxjL+zY4rzqKuZpoA7yX8Olt7RsOgVIjIYeg488xd77l6XnTzLT+Oq0Rb X-Received: by 2002:a05:6512:158e:: with SMTP id bp14mr16414707lfb.509.1629714236181; Mon, 23 Aug 2021 03:23:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629714236; cv=none; d=google.com; s=arc-20160816; b=xgwehSCRJbjh5eJnIHBo4NDicMTh3ZJIGrA2kcEn/ekUJU8XQkc7IKy1Lsd+DzoE7v XjDEpuGwOjmsgC+3dsTQbGg2OrLdjfzrfphWEyABDFPQuMexfmhY+Lguj069DmXxLr7a 8ygB2XEKWMRKPovHJwS32IiVPduf+XH6yTI2ntZw+Ugdg5QcfFE/+j9MczGHVRvimoHr p1IBoiOCgw4eBFv7XamTwPd13X/NqoxX7akYWlRHMGOUAQi8nZ6uIk+m5fZBUKBlWA7w WMw+bBDOJMWhp94obSppKzR5PEIXRQZRDGw7P474p55gRIbG37S3D6JreNN/2BR+/1Nh JKpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=qFnlI2IGo0C8I6UCZZHBH/KVZGaRYx+1kOxGmjGVZhQ=; b=SXSDYoPnEGZ7/LODn+0xebdzYHAumqgZrCJDILSJkJGwxjHBpK5vZuHbIbzHSIEGF+ /Z81a/C62YzHKA0buG5Vc5QxTJ8+wSupOAu6ojuVCzhB0oiu2Vubs+EN8/rNn/Z4pxlc i/oWxBaTS0q8RetjnSmcfiEjzIJOhXYY71B4yhgCF7oLyxFbJRm7O801UbprQAwxjZZq w0+Zg7jPRek6+Hr9ArtLTEJF1oHku5t14FEjuGi54oBLRINpB1OwervWBKBlh1YaXaac GQNB2gvo3RaH7vBvSUB+ErCy+cAu5vPyvjw6kCwpH3ToBbICEIcsiX1Q+PKbb/lC+55S /6Sg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id b27si644816ljo.6.2021.08.23.03.23.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Aug 2021 03:23:56 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-31-27-214-37.mgts.dynamic.pppoe.byfly.by [37.214.27.31] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 17NANo5d001835 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 12:23:51 +0200 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v6 0/6] Restore downstream mounts compatibility Date: Mon, 23 Aug 2021 13:23:36 +0300 Message-Id: <20210823102342.3674387-1-amikan@ilbers.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: O+JyhwOmLrP8 Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken compatibility with downstream projects. Move try-finally from dpkg_runbuild(), etc. to the caller, do_dpkg_build(). Also revert e438c8f62b9aacb2c9d5120e93f81637f091a83c and 3360b7d9ff85172dc3d2275c35caec71149b35ef commits to prevent 'umount: target is busy' issues caused by /dev and /sys mounts stayed locked even after task finish in some cases. Those two commits should be applied back after this issue is found and fixed. Move mounts left printing from warnings to debug output bacause per-task unmounting was reverted. Tested with kas-iot2050-example project from: https://github.com/siemens/meta-iot2050 --- Changes sinse v5: - Revert buildchroot per-task unmounts. - Revert rootfs per-task unmounts. - Remove imager per-task unmounts. Changes sinse v4: - Fix while loop counts. - Move unmount warnings under debug. Changes since v3: - Warn on first entering in umount while loop. - Do not warn on left mounts by default. - Remote incorrect dpkg unmount usage protection. - Rebase on next. - Improve commit messages. Changes since v2: - Remove incorrect buildchroot/rootfs mount/unmount usage protection. - Remove task fail handler. - Implement double mount protection by try-finally. Changes since v1: - Get back while loop in dpkg_undo_mounts. - Exit dpkg_undo_mounts if already mounted. - Do not ignore exceptions in safe_exec. Anton Mikanovich (6): Revert "dpkg: Make mount buildroot reliable" dpkg: Limit unmount loop dpkg-base: Clean up unmounting in do_dpkg_build() events: Do not warn on left mounts by default Revert "rootfs: Unmount rootfs mounts if not needed" Revert "buildchroot: Unmount buildchroot mounts if not needed" meta/classes/buildchroot.bbclass | 47 ------- meta/classes/dpkg-base.bbclass | 123 +++++++----------- meta/classes/dpkg-gbp.bbclass | 8 +- meta/classes/dpkg.bbclass | 14 +- meta/classes/ext4-img.bbclass | 2 - meta/classes/fit-img.bbclass | 2 - meta/classes/image-tools-extension.bbclass | 2 - meta/classes/image.bbclass | 24 ++-- meta/classes/initramfs.bbclass | 2 - meta/classes/isar-events.bbclass | 2 +- meta/classes/rootfs.bbclass | 63 +-------- meta/classes/ubi-img.bbclass | 2 - meta/classes/ubifs-img.bbclass | 2 - meta/classes/wic-img.bbclass | 1 - .../buildchroot/buildchroot.inc | 8 -- 15 files changed, 82 insertions(+), 220 deletions(-) -- 2.25.1