From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7000603433627549696 X-Received: by 2002:a05:6402:b9c:: with SMTP id cf28mr3318715edb.356.1629969502029; Thu, 26 Aug 2021 02:18:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:bb62:: with SMTP id y89ls5390943ede.2.gmail; Thu, 26 Aug 2021 02:18:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCUnx4dq0kQ5lgt7JK+3CXqEtJPg4P0akUwIYsbgHcQAG1rYbavCS2EH+xCxpFRcKwzYyS X-Received: by 2002:a05:6402:1248:: with SMTP id l8mr3177576edw.94.1629969501075; Thu, 26 Aug 2021 02:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629969501; cv=none; d=google.com; s=arc-20160816; b=u0F1Yxrm7XILXLRW/EYnDU1IGhxIHkqdiuJs0FMtJwLz9u4zZ1syhp8Y3HF+YneMP/ 75v0lzvP2jlZg37KEPlUBSnjT+fpbLdPnptqEBiecua6S0oGBxd735Xxn+J59tunWsCJ mJS2WZ82ZIaa+f+OjNf0Q/SRKdwFEW0slcwyiWH49U7ywJHIH8nnesGMmMNdAhoja5Ar eYyCFf4JWq/5EXzTAGX30JTOz9IPnE2mebfuTLdxybbgS6NuLTMBNiZIRfxNZQ8viWoz fjBkjsbd+Ddn3b6JdimfRwF+AdVnr4od31FGvgbKAHQHiTW3OmlSK8GuAYMQPOQSnPFD kRHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Iho2sqMEyaT+mivUWRvc6trnEaQlRijN/ICjDE7U/E4=; b=mWG+SnUZPXIg/P34dK9GIzqk52KBbFWcndvbwUEqKtWGSfHMQJmGeFUyLN2qVoLS6i EZVD+Ib9pHhbd7EEekgWFpSQD0WOzZEynRrtznSftKP19Ysg456F28dHk6XIjbE/TWkJ +wGjG9bXzrXA1uBKWUObe4PJCuzxwstOA93ZkCo7bTnnYkxFk1lhRTD5w7u6/JJfQr6J bK9N/eGODvIoJ3s/rqLOpsux3z+5Su8ORU+Uhr0mW2sHKS+QSyix+qgatnkL1d0vhMFQ u1DC0lymmQIUJXP3BUhve8OSSMYLk2xB3/Y6NhT3OdScilXMJMDtZxCmoi9TV8Xi7A0m p+iA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id s18si173090ejo.1.2021.08.26.02.18.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Aug 2021 02:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 17Q9IKij020409 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Aug 2021 11:18:20 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 17Q9IKfE016226; Thu, 26 Aug 2021 11:18:20 +0200 Date: Thu, 26 Aug 2021 11:18:20 +0200 From: Henning Schild To: Srinuvasan A Cc: Subject: Re: [PATCH] debian-common: Add fdisk package as a dependency in wic Message-ID: <20210826111820.61d8d3bf@md1za8fc.ad001.siemens.net> In-Reply-To: <20210826051603.3649442-1-Srinuvasan_A@mentor.com> References: <20210826051603.3649442-1-Srinuvasan_A@mentor.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: NL59SjDlrtZF Am Thu, 26 Aug 2021 10:46:03 +0530 schrieb Srinuvasan A : > From: Srinuvasan A > > When we build the bullseye images for de0-nano-soc target it's getting > failed in wic image creation step due to sfdisk required to build the > wic images. > > We added --syste-id to WKS file and triggered the builds for buster as --system-id > well as bullseye, buster image got passed, might be that indirectly > pull the fdisk package but bullseye builds got failed hence added this > package as a dependency in wic imager install. It is not might be, it is for sure. See https://github.com/ilbers/isar/blob/03124cca669f50b682336a0bdf4ede5a4238e144/scripts/lib/wic/plugins/imager/direct.py#L592 So maybe change the wording here accordingly. You could add Fixes: c8eb30bfbff4 ("wic-img: import support for .wks.in files from oe-core") So ack to the patch, but commit message should be improved. Henning > Signed-off-by: Srinuvasan A > --- > meta/conf/distro/debian-common.conf | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/conf/distro/debian-common.conf > b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644 > --- a/meta/conf/distro/debian-common.conf > +++ b/meta/conf/distro/debian-common.conf > @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \ > e2fsprogs \ > python3 \ > bmap-tools \ > - tar" > + tar \ > + fdisk" > > GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin" > GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"