[PATCH] debian-common: Add fdisk package as a dependency in wic

[PATCH] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan A]

From: Srinuvasan A <srinuvasan_a@mentor.com>

When we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

We added --syste-id to WKS file and triggered the builds for buster as
well as bullseye, buster image got passed, might be that indirectly pull
the fdisk package but bullseye builds got failed hence added this
package as a dependency in wic imager install.

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
-- 
2.25.1

Re: [PATCH] debian-common: Add fdisk package as a dependency in wic

[Henning Schild]

Am Thu, 26 Aug 2021 10:46:03 +0530
schrieb Srinuvasan A <Srinuvasan_A@mentor.com>:

> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> When we build the bullseye images for de0-nano-soc target it's getting
> failed in wic image creation step due to sfdisk required to build the
> wic images.
> 
> We added --syste-id to WKS file and triggered the builds for buster as

--system-id

> well as bullseye, buster image got passed, might be that indirectly
> pull the fdisk package but bullseye builds got failed hence added this
> package as a dependency in wic imager install.

It is not might be, it is for sure. See

https://github.com/ilbers/isar/blob/03124cca669f50b682336a0bdf4ede5a4238e144/scripts/lib/wic/plugins/imager/direct.py#L592

So maybe change the wording here accordingly.

You could add 
Fixes: c8eb30bfbff4 ("wic-img: import support for .wks.in files from oe-core")

So ack to the patch, but commit message should be improved.

Henning

> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/distro/debian-common.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/debian-common.conf
> b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
>                        e2fsprogs \
>                        python3 \
>                        bmap-tools \
> -                      tar"
> +                      tar \
> +                      fdisk"
>  
>  GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
>  GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"

[PATCH] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan A]

From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref for de0-nano-soc.wks.in: https://github.com/ilbers/isar/commit/c8eb30bfbff4dc22c6d9633f33646e99590853d9

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
-- 
2.25.1

Re: [PATCH] debian-common: Add fdisk package as a dependency in wic

[Henning Schild]

Should be "v2" see "--subject-prefix" in "git send-email"

Am Thu, 26 Aug 2021 17:46:40 +0530
schrieb Srinuvasan A <Srinuvasan_A@mentor.com>:

> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> In downstream when we build the bullseye images for de0-nano-soc
> target it's getting failed in wic image creation step due to sfdisk
> required to build the wic images.
> 
> To reproduce this issue in upstream we triggered the de0-nano-soc
> build with --system-id option enabled in wks.in file, this issue
> present in upstream build hence added the dependency package fdisk to
> the wic imager install.
> 
> Ref for de0-nano-soc.wks.in:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Filbers%2Fisar%2Fcommit%2Fc8eb30bfbff4dc22c6d9633f33646e99590853d9&amp;data=04%7C01%7Cde173c00-e982-4fda-8644-47edf4671d63%40ad011.siemens.com%7C8d5cac41bb6b45120ee308d9688b6d6b%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637655770766182740%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=2QWon3o9OYfdb%2BpQjlokZL8mkbbV4K8gT8MkuRa395c%3D&amp;reserved=0

Forgive the f..ed up link. But naming a ref in the same repo is best
just done with that ref. So please just the sha maybe shortened to 8 or
12 leading chars.

gitk and other repo browsers will allow navigation when just using
the sha ... think of it as a much better relative link as opposed to
the absolute one you suggest here.

Henning

> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/distro/debian-common.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/debian-common.conf
> b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
>                        e2fsprogs \
>                        python3 \
>                        bmap-tools \
> -                      tar"
> +                      tar \
> +                      fdisk"
>  
>  GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
>  GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"

[PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan A]

From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
-- 
2.25.1

[PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan A]

From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
-- 
2.25.1

[PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan A]

From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
-- 
2.25.1

Re: [PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Henning Schild]

Looking good now.

I guess we could switch the "default" distro of Isar from buster to
bullseye soon, that finding/fix will ease that step.

And introduce bookwork while at it.

Henning

Am Fri, 27 Aug 2021 18:35:37 +0530
schrieb Srinuvasan A <Srinuvasan_A@mentor.com>:

> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> In downstream when we build the bullseye images for de0-nano-soc
> target it's getting failed in wic image creation step due to sfdisk
> required to build the wic images.
> 
> To reproduce this issue in upstream we triggered the de0-nano-soc
> build with --system-id option enabled in wks.in file, this issue
> present in upstream build hence added the dependency package fdisk to
> the wic imager install.
> 
> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/distro/debian-common.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/debian-common.conf
> b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
>                        e2fsprogs \
>                        python3 \
>                        bmap-tools \
> -                      tar"
> +                      tar \
> +                      fdisk"
>  
>  GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
>  GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"

Re: [PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Anton Mikanovich]

27.08.2021 16:17, Srinuvasan A wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> In downstream when we build the bullseye images for de0-nano-soc target it's getting
> failed in wic image creation step due to sfdisk required to build the
> wic images.
>
> To reproduce this issue in upstream we triggered the de0-nano-soc build
> with --system-id option enabled in wks.in file, this issue present in
> upstream build hence added the dependency package fdisk to the wic
> imager install.
>
> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>

This will fail in stretch, because there is no such a package in it.
sfdisk was already included in util-linux, but moved to separate fdisk 
package started from buster.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Jan Kiszka]

On 06.09.21 15:48, Anton Mikanovich wrote:
> 27.08.2021 16:17, Srinuvasan A wrote:
>> From: Srinuvasan A <srinuvasan_a@mentor.com>
>>
>> In downstream when we build the bullseye images for de0-nano-soc
>> target it's getting
>> failed in wic image creation step due to sfdisk required to build the
>> wic images.
>>
>> To reproduce this issue in upstream we triggered the de0-nano-soc build
>> with --system-id option enabled in wks.in file, this issue present in
>> upstream build hence added the dependency package fdisk to the wic
>> imager install.
>>
>> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
>>
>> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> This will fail in stretch, because there is no such a package in it.
> sfdisk was already included in util-linux, but moved to separate fdisk
> package started from buster.
> 

WIC_IMAGER_INSTALL_remove_stretch = "fdisk"

should fix that and can easily be dropped when we retire stretch.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Re: [PATCH v3] debian-common: Add fdisk package as a dependency in wic

[Srinuvasan Arjunan]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

Sure jan, will send next version of patch soon.

Many thanks,
Srinuvasan.A

On Tue, 7 Sep, 2021, 12:11 am Jan Kiszka, <jan.kiszka@siemens.com> wrote:

> On 06.09.21 15:48, Anton Mikanovich wrote:
> > 27.08.2021 16:17, Srinuvasan A wrote:
> >> From: Srinuvasan A <srinuvasan_a@mentor.com>
> >>
> >> In downstream when we build the bullseye images for de0-nano-soc
> >> target it's getting
> >> failed in wic image creation step due to sfdisk required to build the
> >> wic images.
> >>
> >> To reproduce this issue in upstream we triggered the de0-nano-soc build
> >> with --system-id option enabled in wks.in file, this issue present in
> >> upstream build hence added the dependency package fdisk to the wic
> >> imager install.
> >>
> >> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
> >>
> >> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> >
> > This will fail in stretch, because there is no such a package in it.
> > sfdisk was already included in util-linux, but moved to separate fdisk
> > package started from buster.
> >
>
> WIC_IMAGER_INSTALL_remove_stretch = "fdisk"
>
> should fix that and can easily be dropped when we retire stretch.
>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/f5dc1714-0eee-77e5-be30-035d82e0c2ed%40siemens.com
> .
>

[-- Attachment #2: Type: text/html, Size: 2771 bytes --]