From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7003689951757860864 X-Received: by 2002:a7b:cb53:: with SMTP id v19mr10560282wmj.127.1630918745480; Mon, 06 Sep 2021 01:59:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ef0d:: with SMTP id e13ls649232wro.3.gmail; Mon, 06 Sep 2021 01:59:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMJoZGD89ZIAub3Kh+Vgo3xx04rQQL60yiaeLAA/Jk9hdMIq7tBQDRzmBwqL6Q8u/wr/k1 X-Received: by 2002:a05:6000:352:: with SMTP id e18mr11885407wre.238.1630918744583; Mon, 06 Sep 2021 01:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630918744; cv=none; d=google.com; s=arc-20160816; b=xLHtRXiHCwASrFjXykWQ1TCOXuxkOau19/9Q24CnkXoSCyvN5J8QTBHKLNStHPXvaX imX9Lr2lJzEVsM5j2K0td//aezZVML3IyDL+zNNrpLxWfE2TehlGsrhJIu1nUdmGs7yo 3CPYjO3J1CiiqpOxBJ9Tgs/wuz+HRBac8P/aC55zCKHT843AYPlR3ovbparVhiM/Wv6w lJRK+nM+qNUAx0LB2d7+2R7yt4FOZDLdLZTnD3qQOEA4iw7M81ke3od6uG+JIWPpNtKm 1P03bfgeHu3Gyuht48TJILfCLQ5T2ZbOFLiLXcz8AOnbtNt/7nye45NmsuSzb7kA8qNV Bm0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=z1GTtIdFo5YhThzJhss7GF9iGa2BCLI08XuvLFYbRI8=; b=XAVb4uSJGvXhIkStRY9wQ+xG+4ufQynohDA/8RlVcIs0txbQSVlUzpGCA7j42n+sWp xP7nMF8GEbIJWHlFlDflHcMjRDD1JOztRIv70F3jlK/wbZUQc/sMGjEAqzS9OvizkI8g A+3nUjB5k2wsAi+RpPIWyjrAwdjOlnnm1rVfq4xQcfLIb7TRReS91S3V71JDPVVF6awt WEGcDPzhQ744G0Wg9kWc8KbrCUxfxoWVmOy4GpsmddKCpargZM2RZbL2xDVZmdGopOMJ PZoDVGrKrtI84QugR+bace7afYQT2akVia1HE9F9OT1j+/sJ2piX6QIzuRFzjanm0+n2 p6+w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id i7si49915wrn.2.2021.09.06.01.59.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Sep 2021 01:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1868x4Iu016344 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Sep 2021 10:59:04 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1868x3P9000711; Mon, 6 Sep 2021 10:59:04 +0200 Date: Mon, 6 Sep 2021 10:59:02 +0200 From: Henning Schild To: Jan Kiszka Cc: , Florian Bezdeka , Vijai Kumar K Subject: Re: [PATCH v2 0/7] re-fork wic pcbios and efi plugins Message-ID: <20210906105902.35dcb338@md1za8fc.ad001.siemens.net> In-Reply-To: <02091f27-08ca-a3ab-504e-ff1e15bff2cd@siemens.com> References: <20210903125355.12279-1-henning.schild@siemens.com> <02091f27-08ca-a3ab-504e-ff1e15bff2cd@siemens.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: B/0vAomC2iNn Am Mon, 6 Sep 2021 07:05:17 +0200 schrieb Jan Kiszka : > On 03.09.21 14:53, Henning Schild wrote: > > changes since v1: > > - efi plugin forked as well > > - systemd-boot support in efi plugin enabled > > - common functionality in utility library > > - test case for system-boot > > - "cp -a" moved to "find exec cp" because of ubuntu > > - changed wks files to exclude boot from root and mount it > > > > The forked plugins have gotten out of sync with the last wic version > > bumps. And the original fork was not exactly minimal or made for > > easy maintenance. > > > > This series does a re-fork of the two plugins with the aim to come > > up with something readable, minimal and maintainable. > > > > I already pointed this out to Baurzhan: We should create some > developer doc somewhere that list the update procedures for forked > elements. Which files come from upstream? Which are supposed to be > vanilla? Which contain changes and should be revisited when upstream > is updated? With such a file, both maintainers and contributors can > check what to do when the want to update affected files / components > or see patches touching them. > > Maybe start that file with covering wic and its plugins? This is a good idea but i would not want to include a patch into this series. Something to do on top. The main reason is that we also have half-forked bits like the wks files and especially meta/classes/wic-img.bbclass which probably has not been checked in a long time. > > There used to be a special case for grub-efi where the actual > > kernel and initrd would remain in the root partition, which kind of > > allowed kernel updates with apt-get. Now all three bootloaders > > (systemd-boot now works as well) place bootloader, config and boot > > artifacts in a boot-partition. > > > > Kernel updates with apt-get are now consistantly "broken". That > > consistency very likely is not too bad. A generic solution for this > > feature (if wanted) will need to be found. Covering not just these > > three bootloaders but possibly also u-boot and efibootguard. > > I assume that this only applies to efi and pcbios images, not > u-boot-script or anything else that manages kernel updates more or > less properly already. Right. The u-boot plugin is not a fork but our own. It might contain copied bits but i did not look at it at all. And it is currently the only bootloader bringing an update-script to generate bootloader conf when updating the kernel with apt-get. At a later point we can see if we can enable "apt-get update " bootloader indep. I think that should be possible very similar to how we do things for u-boot. But that is a story for the future, after this series has been merged. I see it as a win to move from "mostly broken" to "consistently broken". The only case that sometimes worked was grub ... depending on which wic version and whether one would mount at /boot. Henning > Jan >