From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7004754512489480192 X-Received: by 2002:a05:6512:baa:: with SMTP id b42mr9077491lfv.50.1630925314067; Mon, 06 Sep 2021 03:48:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4146:: with SMTP id c6ls945127lfi.2.gmail; Mon, 06 Sep 2021 03:48:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhc14uEEn/MN8+5NXpwTwcaA8fg5BqxiBAOu5fvpiPzJnepi+hhlNfJ9GPF/E0VXmmUukC X-Received: by 2002:a05:6512:3b93:: with SMTP id g19mr8700612lfv.53.1630925312995; Mon, 06 Sep 2021 03:48:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630925312; cv=none; d=google.com; s=arc-20160816; b=ytljhtpnU5CFgjQ9j0xN4n5mqhwvV2JM0J+A0vpVsuQWaSzQC63wPf56IQAzGXv5Zy tP3IbYDuB0cyYKzxJuzO3490Ts6G+pJxJbYagtTh823+Pzkl6uUQENOHOfyLeTO3t3Pa Mx6TebtnRu/Bi5UvrygWp7vgmLgkCjvXTBxV8LxN5RieeYyvHcvOpxYNzKx9C6sWeJ2w PWAvkqkMRQDFDCN6kYvtc5sqgVyyJLDz6uW7UfZtuW3reczCQRWwnBH9Z1vhpo9ukmHe WZE7/qiAlypvTZG5SIvmKfeDrl5VTL54MaLsIZo++uZDLvX+CF+7ojpNIItA4vgdDON1 ZtyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=zW6MF+yidmIqC9yYRuFVWdppNk+PFWKANGFUWiwiD9w=; b=vNDxebtls5hJSDOD7Zlp+hWTK7NRCM07uSy7NrBYeGEeJDfoMIk115A6at6/cMbky1 Su4TLHBzJkr+3GunqRO+8/k6iAdlXK0s/kxU2osn4+0jmY08tN/7fZsIbePx1xT86W2v u2isxpdQzVgemmGNnzTwUMXiJUDVWLYbgYN3oD5tjlcXywEHCYK9ACLwNlUOt5ZOeVWd 7I/dvMiAa4XypwRHOWsHrrQS/xIjyseHvUQISRhYdMbVrDvdNd5TP3kBx/Dc6M8VxOrj cCaedrjf7+ixDSzliMkxT7lvsfpQYsreb8VVOMYFYVFEZQe4ycNLRdVaLIPrcPVziUd3 8N4A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id j5si223505ljq.0.2021.09.06.03.48.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Sep 2021 03:48:32 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 186AmWIB020102 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Sep 2021 12:48:32 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 186AmVnL002266; Mon, 6 Sep 2021 12:48:31 +0200 Date: Mon, 6 Sep 2021 12:48:31 +0200 From: Henning Schild To: Cc: , Subject: Re: [isar] rootfs: Add new ROOTFS_FEATURE 'slimfy' to minimize the footprint Message-ID: <20210906124831.202ce22f@md1za8fc.ad001.siemens.net> In-Reply-To: <20210906094510.9589-1-venkata.pyla@toshiba-tsip.com> References: <20210906094510.9589-1-venkata.pyla@toshiba-tsip.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Fbzt9K6dpYvn IMHO no need to model that as a feature. Removing "temporary" files that do not belong to packages is something everybody would expect anyways. Am Mon, 6 Sep 2021 15:15:10 +0530 schrieb : > From: venkata pyla > > This Adds new ROOTFS_FEATURE 'slimify' that deletes unnecessary files > in the rootfs and contributes to minimal footprint in the rootfs and > also avoids the reproducible failures due to non-deterministic data > in the log files and temporary files. > > It deletes the following files > - /var/log/* > - /tmp/* > > To enable this feature > ROOTFS_FEATURE += slimify > > Signed-off-by: venkata pyla > --- > meta/classes/rootfs.bbclass | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index f9151c5..d01a9d1 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?= "" > # 'clean-package-cache' - delete package cache from rootfs > # 'generate-manifest' - generate a package manifest of the rootfs > into ${ROOTFS_MANIFEST_DEPLOY_DIR} # 'export-dpkg-status' - exports > /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} +# > 'slimify' - delete unnecessary files in rootfs like > /var/log/*, /tmp/* ROOTFS_FEATURES ?= "" > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > @@ -229,6 +230,12 @@ rootfs_export_dpkg_status() { > '${ROOTFS_DPKGSTATUS_DEPLOY_DIR}'/'${PF}'.dpkg_status > } > > +ROOTFS_POSTPROCESS_COMMAND += > "${@bb.utils.contains('ROOTFS_FEATURES', 'slimify', 'rootfs_slimify', > '', d)}" +rootfs_slimify() { > + sudo rm -rf "${ROOTFSDIR}/var/log/"* This is going too far because you are removing package content i.e. dpkg -S /var/log/apt apt: /var/log/apt If packages ship directories or maybe even files we can not simply delete those. And overall the change is not going far enough. Because i.e. /var/lib and /var/cache remain as problems. Instead of listing a bunch of directories we should really go and ask the package manager which files are without owner. Henning > + sudo rm -rf "${ROOTFSDIR}/tmp/"* > +} > + > do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}" > python do_rootfs_postprocess() { > # Take care that its correctly mounted: