From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:ac2:4c4b:: with SMTP id o11mr3008517lfk.183.1631116135001; Wed, 08 Sep 2021 08:48:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:91cf:: with SMTP id u15ls571456ljg.11.gmail; Wed, 08 Sep 2021 08:48:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9KYntGMVRGF/szngNasTabXMcbzSKKNSmIsyaE/DYPoc7korPoL9qQV2TnLgCu3bziD9N X-Received: by 2002:a2e:2417:: with SMTP id k23mr3274171ljk.256.1631116132961; Wed, 08 Sep 2021 08:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631116132; cv=none; d=google.com; s=arc-20160816; b=P4P9wWWOY4JQGIFkVlZmZ5FtJvYklsUhQGP1UM067mmMDIkpncVDReJkJHw71iylpB tULpOtMMdY2EAlxnJBJv0Juirmp08xqgSs8jLQcACSeReOwx9Wodv1bGXK7k51KrJ9/N xPu+Gvcbl/WqSQYCAKCNHfAHOSd4E1TZqf6HEDys+u9xEPmzbr5jl2bChFlFmm4+nrp/ Xmf6TIJ8QQSn1bu8BaUVBuzc2quyukoFpR13N4llNs5MppcdgX3oprv/3tbk6BlcM2Za 9fAhTwbwR6VzBTJriOiILxeQJhM8hAy6i6ZvCAXxLLoHaYiL5wJY1gyDknoYW5xkljeI DCtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=zmkbpB4kPYkn//+D7+3km+M7ly2UQk5U62SzD5y+Hb0=; b=0v5q8SLvJVOgYjF3DaibLc6FWDuv4JrMatTo0aPDxrg1Anhyv0kGbkJ/cug7hJzjhH qDISeyJ1rqYp2MnMp2n/PDNPZhC9uGmy3NkuNlxX2jkDWtxlN8o5pht8FzKsKaj8wPhq 5mNJKNWuarFlVaNWrOZmtXwUZ71eaoUX6IAeThjTNykzshIRb5oBG4I2qk+7eCWB+27D ak3+20nx0okDjoMO3Li9RMAd5vAuiIdII8Pk38UVgiHImBczXkoKca0w/qbl+YMhUCRs xNk22xZINN8V6iNof0JcW6Yas7FG+l4mOcv2M2qUBkII097+dz/Taf2UDzA1XEBz4Vst 5CdQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z4si159577lfr.2.2021.09.08.08.48.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Sep 2021 08:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 188FmqHr029183 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Sep 2021 17:48:52 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.106]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 188FmpbJ005376; Wed, 8 Sep 2021 17:48:51 +0200 Date: Wed, 8 Sep 2021 17:48:51 +0200 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v6 0/6] Restore downstream mounts compatibility Message-ID: <20210908174851.4d0345fd@md1za8fc.ad001.siemens.net> In-Reply-To: <20210823102342.3674387-1-amikan@ilbers.de> References: <20210823102342.3674387-1-amikan@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 38YOZSuv0kSE Is that what was recently applied to next? We are still having issues some issues with current next and are trying to understand things. One thing i did find is that next contains 57b3dc055837 ("Revert "rootfs: Unmount rootfs mounts if not needed"") which reverts e438c8f62b9a ("rootfs: Unmount rootfs mounts if not needed") this guy 5e563ac4b707 ("rootfs: Use separate mounts lock file") was a fix on top of e438c8f62b9a and now also potentially deserves a revert. Henning Am Mon, 23 Aug 2021 13:23:36 +0300 schrieb Anton Mikanovich : > Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has > broken compatibility with downstream projects. Move try-finally from > dpkg_runbuild(), etc. to the caller, do_dpkg_build(). > > Also revert e438c8f62b9aacb2c9d5120e93f81637f091a83c and > 3360b7d9ff85172dc3d2275c35caec71149b35ef commits to prevent 'umount: > target is busy' issues caused by /dev and /sys mounts stayed locked > even after task finish in some cases. Those two commits should be > applied back after this issue is found and fixed. > > Move mounts left printing from warnings to debug output bacause > per-task unmounting was reverted. > > Tested with kas-iot2050-example project from: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsiemens%2Fmeta-iot2050&data=04%7C01%7Cde173c00-e982-4fda-8644-47edf4671d63%40ad011.siemens.com%7C5185795a8ce7459026e408d966201e24%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637653110414149256%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3zx9%2Bfri6TR4jMdA7hZvvvmmuYYMtJoowPgRhv3peAg%3D&reserved=0 > > --- > Changes sinse v5: > - Revert buildchroot per-task unmounts. > - Revert rootfs per-task unmounts. > - Remove imager per-task unmounts. > Changes sinse v4: > - Fix while loop counts. > - Move unmount warnings under debug. > Changes since v3: > - Warn on first entering in umount while loop. > - Do not warn on left mounts by default. > - Remote incorrect dpkg unmount usage protection. > - Rebase on next. > - Improve commit messages. > Changes since v2: > - Remove incorrect buildchroot/rootfs mount/unmount usage protection. > - Remove task fail handler. > - Implement double mount protection by try-finally. > Changes since v1: > - Get back while loop in dpkg_undo_mounts. > - Exit dpkg_undo_mounts if already mounted. > - Do not ignore exceptions in safe_exec. > > Anton Mikanovich (6): > Revert "dpkg: Make mount buildroot reliable" > dpkg: Limit unmount loop > dpkg-base: Clean up unmounting in do_dpkg_build() > events: Do not warn on left mounts by default > Revert "rootfs: Unmount rootfs mounts if not needed" > Revert "buildchroot: Unmount buildchroot mounts if not needed" > > meta/classes/buildchroot.bbclass | 47 ------- > meta/classes/dpkg-base.bbclass | 123 > +++++++----------- meta/classes/dpkg-gbp.bbclass | > 8 +- meta/classes/dpkg.bbclass | 14 +- > meta/classes/ext4-img.bbclass | 2 - > meta/classes/fit-img.bbclass | 2 - > meta/classes/image-tools-extension.bbclass | 2 - > meta/classes/image.bbclass | 24 ++-- > meta/classes/initramfs.bbclass | 2 - > meta/classes/isar-events.bbclass | 2 +- > meta/classes/rootfs.bbclass | 63 +-------- > meta/classes/ubi-img.bbclass | 2 - > meta/classes/ubifs-img.bbclass | 2 - > meta/classes/wic-img.bbclass | 1 - > .../buildchroot/buildchroot.inc | 8 -- > 15 files changed, 82 insertions(+), 220 deletions(-) >