public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH v6 0/6] Restore downstream mounts compatibility
Date: Thu, 9 Sep 2021 11:17:15 +0200	[thread overview]
Message-ID: <20210909111715.3c7e5da3@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <902bcf06-7857-fb6e-d7df-8a0a9a56d4c0@ilbers.de>

Am Thu, 9 Sep 2021 11:13:37 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> 08.09.2021 18:48, Henning Schild wrote:
> > Is that what was recently applied to next?
> >
> > We are still having issues some issues with current next and are
> > trying to understand things.
> >
> > One thing i did find is that next contains
> > 57b3dc055837 ("Revert "rootfs: Unmount rootfs mounts if not
> > needed"")
> >
> > which reverts
> > e438c8f62b9a ("rootfs: Unmount rootfs mounts if not needed")
> >
> > this guy
> > 5e563ac4b707 ("rootfs: Use separate mounts lock file")
> >
> > was a fix on top of e438c8f62b9a and now also potentially deserves a
> > revert.
> >
> > Henning  
> 
> Yes, that was already applied to next.
> What kind of issues do you have, are there any logs?

I just wrote an email on that. Some builds are getting stuck and it
seems that ROOTFS/isar.lock is part of the problem. The layer does have
a few recipes that use buildchroot_do_mounts but nothing with locking.
Investigation is ongoing, but if you know the problem that builds get
stuck at do_deploy_deb that would be interesting to us.

> The lockfile changed by 5e563ac4b707 was gone with revert, because it 
> was introduced by e438c8f62b9a.

I see 57b3dc05583743781cad3b46bec915a601d2fbe2 in fact reverts multiple
commits.

It would be helpful to revert single commits in reverse order and _not_
remove the part of the commit message that contains the sha of the
reverted commit.

Henning

  reply	other threads:[~2021-09-09  9:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 10:23 Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 1/6] Revert "dpkg: Make mount buildroot reliable" Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 2/6] dpkg: Limit unmount loop Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 3/6] dpkg-base: Clean up unmounting in do_dpkg_build() Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 4/6] events: Do not warn on left mounts by default Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 5/6] Revert "rootfs: Unmount rootfs mounts if not needed" Anton Mikanovich
2021-08-23 10:23 ` [PATCH v6 6/6] Revert "buildchroot: Unmount buildchroot " Anton Mikanovich
2021-08-27 17:16 ` [PATCH v6 0/6] Restore downstream mounts compatibility Anton Mikanovich
2021-08-30  8:25   ` Jan Kiszka
2021-08-30 18:46 ` Anton Mikanovich
2021-09-08 15:48 ` Henning Schild
2021-09-09  8:13   ` Anton Mikanovich
2021-09-09  9:17     ` Henning Schild [this message]
2021-09-13 15:03       ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210909111715.3c7e5da3@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox