public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH 1/5] image: Make WORKDIR and STAMPs unrelated to IMAGE_TYPE
Date: Mon, 13 Sep 2021 16:58:06 +0200	[thread overview]
Message-ID: <20210913145810.26394-2-ubely@ilbers.de> (raw)
In-Reply-To: <20210913145810.26394-1-ubely@ilbers.de>

If we want to support several image types listed in IMAGE_TYPE,
we should remove this part from WORKDIR and STAMP and STAMPCLEAN.

This leads to sharing the same directories by parallel builds like
mc:qemuamd64-buster and mc:qemuamd64-buster-tgz that differs only
in used image type.

Technically, this commit reverts the commit 6374a763c988
(image: Make WORKDIR and STAMPs IMAGE_TYPE-specific).

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/classes/image.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index ec93cab..eecada3 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -2,9 +2,9 @@
 # Copyright (C) 2015-2017 ilbers GmbH
 
 # Make workdir and stamps machine-specific without changing common PN target
-WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}-${IMAGE_TYPE}/${PV}-${PR}"
-STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}-${IMAGE_TYPE}/${PV}-${PR}"
-STAMPCLEAN = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}-${IMAGE_TYPE}/*-*"
+WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}/${PV}-${PR}"
+STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}/${PV}-${PR}"
+STAMPCLEAN = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}/*-*"
 
 IMAGE_INSTALL ?= ""
 IMAGE_TYPE    ?= "ext4-img"
-- 
2.20.1


  reply	other threads:[~2021-09-13 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 14:58 [PATCH 0/5] Support multiple image types in one build Uladzimir Bely
2021-09-13 14:58 ` Uladzimir Bely [this message]
2021-09-13 14:58 ` [PATCH 2/5] wic-img: Set weak default value for WKS_FILE Uladzimir Bely
2021-09-13 14:58 ` [PATCH 3/5] start_vm: Use the first image type to start VM Uladzimir Bely
2021-09-13 14:58 ` [PATCH 4/5] meta-isar: Rework mc:qemuamd64-buster configs Uladzimir Bely
2021-09-13 14:58 ` [PATCH 5/5] api: Rename IMAGE_TYPE to IMAGE_FSTYPES Uladzimir Bely
2021-09-13 18:27   ` Jan Kiszka
2021-09-14  7:08     ` Uladzimir Bely
2021-09-14  7:39       ` Jan Kiszka
2021-09-14  7:50         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913145810.26394-2-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox