public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>,
	<Venkata.Pyla@toshiba-tsip.com>
Subject: Re: [PATCH 3/3] isar-exclude-docs: include "native" package changelogs
Date: Tue, 21 Sep 2021 09:24:23 +0200	[thread overview]
Message-ID: <20210921092423.737f1136@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20210906083403.25163-3-henning.schild@siemens.com>

I reported the issue with the changelog upstream and it has been fixed
there.

https://bugs.launchpad.net/bugs/1943114

So now this patch is in line with what ubuntu does to shrink their
cloud/container images.

Henning

Am Mon, 6 Sep 2021 10:34:03 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> So called "native" packages will put the debian changelog into the
> package as "changelog" and not "changelog.Debian".
> dh_installchangelogs(1)
> 
> We have the file from ubuntu and with this change we start doing
> things differently. For isar "raw" packages will be "native" so we
> probably want that no matter what ubuntu might think. I still started
> a discussion on the topic.
> https://github.com/tianon/docker-brew-ubuntu-core/issues/216
> 
> This was found when working on reproducible builds, for some reason
> the changelogs of the raw packages did not differ, because they are
> not in the rootfs.
> 
> Reported-by: <Venkata.Pyla@toshiba-tsip.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs  | 2
> +- meta/recipes-support/isar-exclude-docs/files/postinst           |
> 2 +- .../{isar-exclude-docs_0.1.bb => isar-exclude-docs_0.2.bb}
> | 0 3 files changed, 2 insertions(+), 2 deletions(-)
>  rename
> meta/recipes-support/isar-exclude-docs/{isar-exclude-docs_0.1.bb =>
> isar-exclude-docs_0.2.bb} (100%)
> 
> diff --git
> a/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs
> b/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs
> index 5bec6260fddd..a77a47d1fe01 100644 ---
> a/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs +++
> b/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs @@
> -8,4 +8,4 @@ path-exclude=/usr/share/doc/*
> path-include=/usr/share/doc/*/copyright # ... and Debian changelogs
> -path-include=/usr/share/doc/*/changelog.Debian.*
> +path-include=/usr/share/doc/*/changelog.*
> diff --git a/meta/recipes-support/isar-exclude-docs/files/postinst
> b/meta/recipes-support/isar-exclude-docs/files/postinst index
> f6c0d1b2df52..d34c04ea47f0 100644 ---
> a/meta/recipes-support/isar-exclude-docs/files/postinst +++
> b/meta/recipes-support/isar-exclude-docs/files/postinst @@ -4,4 +4,4
> @@ # what we delete needs to be in sync with the dpkg configuration
> we ship 
>  rm -rf /usr/share/man/*
> -find /usr/share/doc/ -type f ! -name "copyright" ! -name
> "changelog.Debian.*" -exec rm -rf {} \; +find /usr/share/doc/ -type f
> ! -name "copyright" ! -name "changelog.*" -exec rm -rf {} \; diff
> --git
> a/meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.1.bb
> b/meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.2.bb
> similarity index 100% rename from
> meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.1.bb
> rename to
> meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.2.bb


  reply	other threads:[~2021-09-21  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  8:34 [PATCH 1/3] debianize: make changelog date reproducible Henning Schild
2021-09-06  8:34 ` [PATCH 2/3] debianize: prepend changelog entries Henning Schild
2021-09-06  8:34 ` [PATCH 3/3] isar-exclude-docs: include "native" package changelogs Henning Schild
2021-09-21  7:24   ` Henning Schild [this message]
2021-09-07 12:55 ` [PATCH 1/3] debianize: make changelog date reproducible Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921092423.737f1136@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=Venkata.Pyla@toshiba-tsip.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox