From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7004736244321091584 X-Received: by 2002:a5d:4522:: with SMTP id j2mr1777039wra.212.1632209065738; Tue, 21 Sep 2021 00:24:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a285:: with SMTP id s5ls1514591wra.1.gmail; Tue, 21 Sep 2021 00:24:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJDczJudDfbYJZXngcx6r7hSfWxAV2K+PM3RnpcUur+9aX4oar8dKJzOO4kUvO07mw190V X-Received: by 2002:a05:6000:1b8d:: with SMTP id r13mr33634676wru.230.1632209064785; Tue, 21 Sep 2021 00:24:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632209064; cv=none; d=google.com; s=arc-20160816; b=gZ3gx1VCsghAPViHKiV2kA3qU46yNLM6/0oc/CFBQwNH/aHpCGtxel4Q2jGK+qk7U1 vaswL2QPdCN4FI99NmBRgiXOxcr1NdVqR0Wm2YuOYFst1pju5Cuvo0Qbl68JF2Fn/jfj Laz0aohblTHsQDKZhQtDMuefY11EluMKmsAIZnuHYczStKegQvcSSI5iCGzH1wxAxCXf j44ZcL3lILm+N3ernO/Zv/kd8HKjDLIjo9pYqXFa/wpBuDUblgOpqVb5MryekjvKBlni iEvD8VR4r7zi72C1HKpg4rRHJ8FQ6RTycFl0M3yj0naNEy0pJMyu102N2aczsCD8D1x7 nwrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=BJMXaHiSMauo8qWlY18ltS+EmicWvAYhpVdD55KYXEY=; b=mpMn9oxhLiV378n2FxjD2Tug6k5EX3ZBe5dU7CR5kQs6pKQSAmnWfkSkFnbabWehVk wXF2pgU4N1m+zcAJcdatt0GR+Q7Thf/lUbusCYdpoZcTtflhr222C3/AedgxFGw8tdhn tjCVl4pE8X4+q0e9SR6q6gMCkdfC0IZcmZTjcKAclOjxtrD4GCxED6D4KGH1/KEwFVae hLO9VFN0SVXxw6Yzt7MI3w+Ou8G+A1BS6Etv+Z16XhUKpGWX338Ud4kecjadon7qYwli +xz62WMBbvXpIw3kC6hO/UmKrNt2WQGd6f+IjNJQ2b0yLgyhNfHMDGa/4a8BNiFU6sEp yIYg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id q195si143114wme.1.2021.09.21.00.24.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Sep 2021 00:24:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 18L7OOLL019981 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Sep 2021 09:24:24 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 18L7OOxB002149; Tue, 21 Sep 2021 09:24:24 +0200 Date: Tue, 21 Sep 2021 09:24:23 +0200 From: Henning Schild To: Cc: Cedric Hombourger , Subject: Re: [PATCH 3/3] isar-exclude-docs: include "native" package changelogs Message-ID: <20210921092423.737f1136@md1za8fc.ad001.siemens.net> In-Reply-To: <20210906083403.25163-3-henning.schild@siemens.com> References: <20210906083403.25163-1-henning.schild@siemens.com> <20210906083403.25163-3-henning.schild@siemens.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Uk/SzCHmugwD I reported the issue with the changelog upstream and it has been fixed there. https://bugs.launchpad.net/bugs/1943114 So now this patch is in line with what ubuntu does to shrink their cloud/container images. Henning Am Mon, 6 Sep 2021 10:34:03 +0200 schrieb Henning Schild : > So called "native" packages will put the debian changelog into the > package as "changelog" and not "changelog.Debian". > dh_installchangelogs(1) > > We have the file from ubuntu and with this change we start doing > things differently. For isar "raw" packages will be "native" so we > probably want that no matter what ubuntu might think. I still started > a discussion on the topic. > https://github.com/tianon/docker-brew-ubuntu-core/issues/216 > > This was found when working on reproducible builds, for some reason > the changelogs of the raw packages did not differ, because they are > not in the rootfs. > > Reported-by: > Signed-off-by: Henning Schild > --- > meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs | 2 > +- meta/recipes-support/isar-exclude-docs/files/postinst | > 2 +- .../{isar-exclude-docs_0.1.bb => isar-exclude-docs_0.2.bb} > | 0 3 files changed, 2 insertions(+), 2 deletions(-) > rename > meta/recipes-support/isar-exclude-docs/{isar-exclude-docs_0.1.bb => > isar-exclude-docs_0.2.bb} (100%) > > diff --git > a/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs > b/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs > index 5bec6260fddd..a77a47d1fe01 100644 --- > a/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs +++ > b/meta/recipes-support/isar-exclude-docs/files/isar-exclude-docs @@ > -8,4 +8,4 @@ path-exclude=/usr/share/doc/* > path-include=/usr/share/doc/*/copyright # ... and Debian changelogs > -path-include=/usr/share/doc/*/changelog.Debian.* > +path-include=/usr/share/doc/*/changelog.* > diff --git a/meta/recipes-support/isar-exclude-docs/files/postinst > b/meta/recipes-support/isar-exclude-docs/files/postinst index > f6c0d1b2df52..d34c04ea47f0 100644 --- > a/meta/recipes-support/isar-exclude-docs/files/postinst +++ > b/meta/recipes-support/isar-exclude-docs/files/postinst @@ -4,4 +4,4 > @@ # what we delete needs to be in sync with the dpkg configuration > we ship > rm -rf /usr/share/man/* > -find /usr/share/doc/ -type f ! -name "copyright" ! -name > "changelog.Debian.*" -exec rm -rf {} \; +find /usr/share/doc/ -type f > ! -name "copyright" ! -name "changelog.*" -exec rm -rf {} \; diff > --git > a/meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.1.bb > b/meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.2.bb > similarity index 100% rename from > meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.1.bb > rename to > meta/recipes-support/isar-exclude-docs/isar-exclude-docs_0.2.bb