From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7010687509260664832 X-Received: by 2002:a2e:5c7:: with SMTP id 190mr13396601ljf.277.1632302896565; Wed, 22 Sep 2021 02:28:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3a83:: with SMTP id q3ls380099lfu.2.gmail; Wed, 22 Sep 2021 02:28:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaD9JjTWidUdlb9kt0agfjPX8nWu+mHY1cQJ1VwQlIowiIQHtsY7V+7PKNEAAVHjzO/4hM X-Received: by 2002:a05:6512:e97:: with SMTP id bi23mr9955540lfb.201.1632302895486; Wed, 22 Sep 2021 02:28:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632302895; cv=none; d=google.com; s=arc-20160816; b=EdCO3ccbOAFrUHulQhWzV94hLa0fyW+MXDKMMzpzRpfR+FEl7LG93xssBQsss7kRNq VbBgphAIActOQe4j7QibiuDoWz9boZErjh6GcwGPQZsfIZpWBElAc3D80JT4EtuujcqT N85XnTXn9YnhZuRP39CyJMzaTRhOilXvaQsXGpmDVSf/cK/ql9rdMSZCQgmNk0rzD6NR bffHvxQ0XprmC0e/pUHk9NcKMqcQvWb2E7KWoKg9Unridmt8vdRD3EEVlUUHcK2ciCKQ /DO6+bhMphHC8s413r75p21dH1kZ7nbkqvxWvfFoCtAPqYeSXP9vcxdefA96SxpkehvM 3stg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=gdKsp/kDqQuacDgP+6MNlFFyp1pp+Q2OMevKGHDJgvM=; b=HMARpaX5h2AS7R33LPsAK2mOUv+tknnLh/068wKCwyyAmmRJZkYJ3oXv7+q5aC58LZ mY6IYVIOHp7MfixfiHdpv1kpVW8sS+qNV3EbRtXgLvInXeCylvBDE2hGgZGyxmZLWCsi PKhfXrE20c8JbvPh505wtywIqq1Ew2+x4UxlsL2JrubI//osNmKi2bKBA1MkbJC85dTC MhYftHLeS2e9TfVOOR2sgKykkDTQRaF0EdT247bN8166L7R8uCgHXG41Gi5nWGlquh2E Htdm0TIeYpKMmV/wcOOlbGuj6057ZgQf9YxRQlmfmkUTD6pDD5P/gKkx8pnHxx3m+NME dkng== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id t12si119550ljh.0.2021.09.22.02.28.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Sep 2021 02:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 18M9SEtm026610 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 22 Sep 2021 11:28:14 +0200 Received: from MD1T0KAC-VM.ad001.siemens.net (md1t0kac.ad001.siemens.net [139.25.68.224]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 18M9S3kD028537; Wed, 22 Sep 2021 11:28:14 +0200 From: Felix Moessbauer To: isar-users@googlegroups.com Cc: henning.schild@siemens.com, jan.kiszka@siemens.com, Felix Moessbauer Subject: [PATCH 3/4] fix race by serialize rootfs_finalize and do_wic_image Date: Wed, 22 Sep 2021 11:27:53 +0200 Message-Id: <20210922092754.3649703-4-felix.moessbauer@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210922092754.3649703-1-felix.moessbauer@siemens.com> References: <20210922092754.3649703-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: eO4YHvAbakyV The do_wic_image task requires a mounted buildchroot. Prior to this patch, the wic_do_mounts task and do_rootfs_finalize were not ordered. By that, the do_rootfs_finalize task could run in parallel and unmount the buildchroot. This is now fixed by adding the do_rootfs_finalize as a task dependency. Signed-off-by: Felix Moessbauer --- meta/classes/wic-img.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass index e495c12..573537c 100644 --- a/meta/classes/wic-img.bbclass +++ b/meta/classes/wic-img.bbclass @@ -147,7 +147,7 @@ python do_wic_image() { bb.build.exec_func("wic_undo_mounts", d) bb.utils.unlockfile(lock) } -addtask wic_image before do_image after do_image_tools +addtask wic_image before do_image after do_image_tools do_rootfs_finalize wic_do_mounts() { buildchroot_do_mounts -- 2.30.2