From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>, <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/4] fix typo in do_rootfs_finalize
Date: Wed, 22 Sep 2021 17:02:39 +0200 [thread overview]
Message-ID: <20210922170239.73091b10@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20210922092754.3649703-2-felix.moessbauer@siemens.com>
ACK. Should go stand-alone in case discussions on the series take time.
But makes we wonder if we can write this as
for point in dev proc sys; do
...
done
that would probably shorten the whole thing, and the next addition of a
mointpoint will likely not make copy/paste mistakes
Henning
Am Wed, 22 Sep 2021 11:27:51 +0200
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> This fixes a typo to make sure the same mountpoint is checked for
> existence and unmounted.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/image.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index ec93cab..1f39690 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -200,7 +200,7 @@ do_rootfs_finalize() {
>
> mountpoint -q '${ROOTFSDIR}/dev' && \
> umount -l ${ROOTFSDIR}/dev
> - mountpoint -q '${ROOTFSDIR}/sys' && \
> + mountpoint -q '${ROOTFSDIR}/proc' && \
> umount -l ${ROOTFSDIR}/proc
> mountpoint -q '${ROOTFSDIR}/sys' && \
> umount -l ${ROOTFSDIR}/sys
next prev parent reply other threads:[~2021-09-22 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:27 [PATCH 0/4] Fix sporadic failures in do_wic_image Felix Moessbauer
2021-09-22 9:27 ` [PATCH 1/4] fix typo in do_rootfs_finalize Felix Moessbauer
2021-09-22 15:02 ` Henning Schild [this message]
2021-09-22 9:27 ` [PATCH 2/4] execute do_wic_image under a lock to ensure mountpoints remain mounted Felix Moessbauer
2021-09-22 15:04 ` Henning Schild
2021-09-22 9:27 ` [PATCH 3/4] fix race by serialize rootfs_finalize and do_wic_image Felix Moessbauer
2021-09-22 15:15 ` Henning Schild
2021-09-23 8:39 ` Moessbauer, Felix
2021-09-22 9:27 ` [PATCH 4/4] split rootfs finalization and unmounting into two tasks Felix Moessbauer
2021-09-22 15:23 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922170239.73091b10@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox