From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 7010687509260664832
X-Received: by 2002:a05:651c:4ce:: with SMTP id e14mr33671670lji.511.1632322962272;
        Wed, 22 Sep 2021 08:02:42 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a05:6512:3a83:: with SMTP id q3ls709178lfu.2.gmail; Wed, 22
 Sep 2021 08:02:41 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwJCfJDF0ZJj8CWkIl+Hp2bssVwC6GASjWvJvbn84x6r7jHntXbqoEtlbHFAWeJI7ViflSX
X-Received: by 2002:a19:c1c3:: with SMTP id r186mr85874lff.400.1632322961203;
        Wed, 22 Sep 2021 08:02:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1632322961; cv=none;
        d=google.com; s=arc-20160816;
        b=IlKlri6fBBGMJYDAu5Ot/i1/fcTv6QgEhymeCWfuRR9ZkbIgX6tOnq0yXzkoA55F+b
         I2ATtktVU18jyiz2CM8Iv9DuOMNYfpP5nWM4gcIt1/dArlea2c4J7Ux8Qp1dW1eRmK0c
         YATVUlwr/Vdih8rVqI3grHuOibW2eaEVvbz1zPl7HUnFxE7l0KSeXpXuWjQG157le7+6
         LlFxJcxc27sm8kUp2+NEbsUH8AvsuLCXmZ8s/dKcnjrPrV2GbHKbmy0Uel6mVhZhguBT
         8ctgL8l9wSmW/tCfmg1vJldMCf+xo377nQGbesgEWmOlYaRrKXq7EpHpSWfMEAzQk8HE
         1D0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:subject:cc:to:from:date;
        bh=DpI+npvglPVYDPj1SRT4z0lNFOQCX9qdt8AMcOwPQGE=;
        b=Ui62963oPGEwWSHPXfvIs26m8Mg7vaUCiz6K1r/EFJrN5T936msBIltaA4Y6BwrpbG
         0NfnO+MVq4HWVca0TlG3auFw3tF4nyJjKl3huJhqRW8EetkWuNo+pe7GcuzxRopltoSS
         mufxcBdzxJaYx1fiIVYwEya54ImDtsBjQKHhVxjy6gN1RuAVXqIDaZLVEEuHlVEuUf7V
         aw/cQMVtyvTWWt4dTKxanDv3isSEPmG78dvREv+a7iobugPulceNRHG8SRFnJk+UZ/j3
         FIbjQijgKjXwDasZTkCBAKpms5IUoedk1JHj1PzgmPEZXqGSD2ts/Z031x01ditMm2zJ
         vkMA==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com
Return-Path: <henning.schild@siemens.com>
Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])
        by gmr-mx.google.com with ESMTPS id o26si107021lfc.4.2021.09.22.08.02.41
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 22 Sep 2021 08:02:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com
Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35])
	by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 18MF2eIj001774
	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
	for <isar-users@googlegroups.com>; Wed, 22 Sep 2021 17:02:40 +0200
Received: from md1za8fc.ad001.siemens.net ([167.87.35.234])
	by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 18MF2e1s023918;
	Wed, 22 Sep 2021 17:02:40 +0200
Date: Wed, 22 Sep 2021 17:02:39 +0200
From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>, <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/4] fix typo in do_rootfs_finalize
Message-ID: <20210922170239.73091b10@md1za8fc.ad001.siemens.net>
In-Reply-To: <20210922092754.3649703-2-felix.moessbauer@siemens.com>
References: <20210922092754.3649703-1-felix.moessbauer@siemens.com>
	<20210922092754.3649703-2-felix.moessbauer@siemens.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-TUID: CkRxbkBBHtxf

ACK. Should go stand-alone in case discussions on the series take time.

But makes we wonder if we can write this as

for point in dev proc sys; do
...
done

that would probably shorten the whole thing, and the next addition of a
mointpoint will likely not make copy/paste mistakes

Henning

Am Wed, 22 Sep 2021 11:27:51 +0200
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:

> This fixes a typo to make sure the same mountpoint is checked for
> existence and unmounted.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index ec93cab..1f39690 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -200,7 +200,7 @@ do_rootfs_finalize() {
>  
>          mountpoint -q '${ROOTFSDIR}/dev' && \
>              umount -l ${ROOTFSDIR}/dev
> -        mountpoint -q '${ROOTFSDIR}/sys' && \
> +        mountpoint -q '${ROOTFSDIR}/proc' && \
>              umount -l ${ROOTFSDIR}/proc
>          mountpoint -q '${ROOTFSDIR}/sys' && \
>              umount -l ${ROOTFSDIR}/sys