Re: [PATCH 3/4] fix race by serialize rootfs_finalize and do_wic_image

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 22 Sep 2021 11:27:53 +0200
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:

> The do_wic_image task requires a mounted buildchroot.
> Prior to this patch, the wic_do_mounts task and do_rootfs_finalize
> were not ordered. By that, the do_rootfs_finalize task could run
> in parallel and unmount the buildchroot.

That is not just a mounting issue. The finalize should be done before
any imager goes to create an image. Because finalize contains quite a
bit of "rm -f".

If the actual imager task and finalize have not been serialized, we
need to look into that for all our imagers, not just wic.

The pattern we use is that imagers usually do

addtask <something>_image before do_image after do_image_tools

and it is also in ubifs cpiogz ext4 fit container ...

We need to touch all of them. Or play a global trick like

addtask image_tools after do_rootfs_finalize

to catch them all and possibly also catch the ones in layers.

Henning

> This is now fixed by adding the do_rootfs_finalize as a task
> dependency.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/wic-img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/wic-img.bbclass
> b/meta/classes/wic-img.bbclass index e495c12..573537c 100644
> --- a/meta/classes/wic-img.bbclass
> +++ b/meta/classes/wic-img.bbclass
> @@ -147,7 +147,7 @@ python do_wic_image() {
>          bb.build.exec_func("wic_undo_mounts", d)
>          bb.utils.unlockfile(lock)
>  }
> -addtask wic_image before do_image after do_image_tools
> +addtask wic_image before do_image after do_image_tools
> do_rootfs_finalize 
>  wic_do_mounts() {
>      buildchroot_do_mounts