From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7004754512489480192 X-Received: by 2002:a05:6512:3fa5:: with SMTP id x37mr14712449lfa.233.1633349116367; Mon, 04 Oct 2021 05:05:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3a83:: with SMTP id q3ls142616lfu.2.gmail; Mon, 04 Oct 2021 05:05:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTctlCoSLqdjAL0A3rjpmiAkTTW6cPwGNklzO9D8J2ON/WvyLzcFYyKZFWDVqBCCx5BPkE X-Received: by 2002:a05:6512:3d93:: with SMTP id k19mr7334188lfv.114.1633349115314; Mon, 04 Oct 2021 05:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633349115; cv=none; d=google.com; s=arc-20160816; b=bldw35QLihRSGItW0zgUNXJL7nZySYuFQnzON6BMJI9KBxdpCh8IRTsPkudP9OdfwR CXUyz6CqCVa31rej+wrFv4gv6RoU1gPT4DGlWxxbcsiAelDQz7yF8W+vXG/w087eb+AJ gWpkr4cPwHAjsm3P1VP6uilavwaP7Om5Trbbc49jcCh33BagsQENFvm+VmLf/xzkX3xx SoQ/Eg44HYjKUxYJMbPp2wqG55O4nusOghrO+CRYj7K/zn+o9xPHCvNzizXoEQJg2oFB dDFUvn3inE9ZiKoXR6sBrdxWoHIVQ7DXQ1aO4nsckyI+VTkUQbRhiG+3Tpsa5xTENZuB fw2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=MdEmPLeXZHpUhCwrlUrgvJV+B4urxxdOI8bHJSCHuWI=; b=SddOIvq09yptAsOQZJzUgqnu52qSYe8cf06jLyWpU5BEoxE58KOca5lTtQ6pasieIp FbFyKemHAfV2RVglsp/25T17WdgdXJsmzmWuVt/D+WSKKapQ1ExOyEIC5OuuLXXAdk+m m05Xsp2c/pTx6AbQF/D7XTkoXW2rsfXkYd4RX6yPLEEjbjRwpXxEY7OyiYemVkTiwQ1T UajbpcypH6ML9nsaQnTerdjVaCuLBRBPD/cy3AJO58/aHgHpi0NzVxwWz/aZt4nrEXHo SfZfnITQMSOzc3+DyFnaoQsQh+ZvMMc6Ty5PsLRixB/hOsLKHga1R8UkZBOCtBFPaAfz qQJg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l25si116366ljj.2.2021.10.04.05.05.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Oct 2021 05:05:15 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 194C5Ejd015564 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Oct 2021 14:05:14 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 194C5E1g007884; Mon, 4 Oct 2021 14:05:14 +0200 Date: Mon, 4 Oct 2021 14:05:13 +0200 From: Henning Schild To: Cc: , Subject: Re: [PATCH v2] rootfs: clean package log files that are not owned by packages Message-ID: <20211004140513.29414a72@md1za8fc.ad001.siemens.net> In-Reply-To: <20211001143748.8711-1-venkata.pyla@toshiba-tsip.com> References: <20210906124831.202ce22f@md1za8fc.ad001.siemens.net> <20211001143748.8711-1-venkata.pyla@toshiba-tsip.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 4zqcHht+Mtdb Am Fri, 1 Oct 2021 20:07:48 +0530 schrieb : > From: venkata pyla > > /var/log/* files that are created during build stage and not owned > by any package are not neccessary to be present in rootfs image, as > these log files adds additional size to rootfs image, and also it > create problems for reproducible build functionality. > > so this ROOTFS feature 'clean-log-files' should help to clean the log > files when it is enalbed, disable it if we need the log files for > debugging purpose. > > ROOTFS_FEATURE += clean-log-files The two leading spaces of the commit message look a little weird. Like you are not using git-format-patch or git-send-email correctly. Or like you are using a funny editor for writing your commit messages. I think that adds value but i do not see why we should model it as a feature. It should probably be the "new normal" and we introduce an option once there is a need for a switch. > Signed-off-by: venkata pyla > --- > meta/classes/rootfs.bbclass | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index f9151c5..ff0ecad 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?= "" > # 'clean-package-cache' - delete package cache from rootfs > # 'generate-manifest' - generate a package manifest of the rootfs > into ${ROOTFS_MANIFEST_DEPLOY_DIR} # 'export-dpkg-status' - exports > /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} +# > 'clean-log-files' - delete log files that are not owned by packages > ROOTFS_FEATURES ?= "" > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > @@ -213,6 +214,15 @@ rootfs_postprocess_clean_package_cache() { > sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* > } > > +ROOTFS_POSTPROCESS_COMMAND += > "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-log-files', > 'rootfs_postprocess_clean_log_files', '', d)}" > +rootfs_postprocess_clean_log_files() { > + # Delete log files that are not owned by packages > + sudo -E chroot '${ROOTFSDIR}' \ > + /usr/bin/find /var/log/ \ > + -exec sh -c '! dpkg -S {} > /dev/null 2>&1' ';' \ > + -exec rm -rf {} ';' I think we should restrict that to "-type f" and switch over to "rm -f" (not -r) Henning > +} > + > ROOTFS_POSTPROCESS_COMMAND += > "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', > 'rootfs_generate_manifest', '', d)}" rootfs_generate_manifest () { > mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}