Re: [PATCH] meta/classes/debianize: Create debian folder if source does not contain one

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 29 Sep 2021 18:53:52 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> On 29.09.21 17:43, Michael Ebel wrote:
> > From e4f8153bd3b3886b283ea19517b56f5190ca6b9a Mon Sep 17 00:00:00
> > 2001 From: Michael Ebel <mebel@christ-es.de>
> > Date: Wed, 29 Sep 2021 16:29:40 +0200
> > Subject: [PATCH] meta/classes/debianize: Create debian folder if 
> > source does
> >  not contain one
> >
> > Signed-off-by: Michael Ebel <mebel@christ-es.de>
> > ---
> >  meta/classes/debianize.bbclass | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/classes/debianize.bbclass 
> > b/meta/classes/debianize.bbclass
> > index 4486778..338b1f5 100644
> > --- a/meta/classes/debianize.bbclass
> > +++ b/meta/classes/debianize.bbclass
> > @@ -88,6 +88,11 @@ EOF
> >  }
> >
> >  deb_debianize() {
> > +    # create the debian folder if the source does not contain it
> > +    if [ ! -d ${S}/debian ]; then
> > +        install -v -m 755 -d ${S}/debian
> > +    fi
> > +
> >      # create the compat-file if there is no file with that name in 
> > WORKDIR
> >      if [ -f ${WORKDIR}/compat ]; then
> >          install -v -m 644 ${WORKDIR}/compat ${S}/debian/compat
> > -- 
> > 2.25.1  
> 
> Using flag `task_function[cleandirs] += "${S}/debian"` looks much
> cleaner. You can look at
> meta-isar/recipes-app/samefile/samefile_2.14.bb for the reference.

In general using cleandirs is probably the nicer solution, but that is
on recipe level and depends on whether one really wants it to be
cleaned. You can also imagine "SRC_URI = file:///debian" where a
pre-filled folder is fetched and that task should not clean.

So the patch is valid, there is code placing files in a potentially
non-existing directory, which should be created on demand.

Henning