From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7013366436890411008 X-Received: by 2002:a05:600c:210d:: with SMTP id u13mr9948896wml.146.1633364730606; Mon, 04 Oct 2021 09:25:30 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1caa:: with SMTP id k42ls2485107wms.3.canary-gmail; Mon, 04 Oct 2021 09:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDb2Q5ZQD3lPIVFRwCJzo4KP2qGgOCGhpFLG/KGBRLM3DGUDAPi6H8YEKzgMK9apN7lYNf X-Received: by 2002:a1c:496:: with SMTP id 144mr12289166wme.60.1633364729703; Mon, 04 Oct 2021 09:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633364729; cv=none; d=google.com; s=arc-20160816; b=PCKorFcyCpf6t9SUAm5dtxwXgjOPy6PMYWx0zlEALMDLMYNFzGZco32qszTNbEH5r0 c8J6XTiL3PXi5OdceeRpkMnoF1FYvHNnq5SHdHQ3IiIEr+TEpfzf6d7Zx01nWKurTdKy g0X1wYIUE+ULH9Y3YLQwCaIw2pXGkTshYb5a42FH5CBk6BbCW9AP0gGaTdJ6l/oM9/AP QQLx0ojDQ4Y2+mvIPuctQELnpxO0vibg0BcAOTb9hYWqLNnPlM5OwjCS3JiZaUEErBcg Cf2emgyrw57SfYyDNhoS0ZVKxduiFO27WTKJfF5UVOuBGwCkX+N07v8BK34SWNy8fWBw PeCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=p5SnMe55qO5b/fFc7BmpCOHa5Qzo3vV1dP28sgM8SN4=; b=bltFaQkOwGNhjIyKCbedVce6/7u4ofmeEym6MSsyxz1oJZUBYQllgE2kXyUrm5rfzK 1zFkb93qy4XhWfGP6eKchWH0kRVJK8pxVIlmq9ivtUc37UAhHXmpJoAltt5+nKc5XZeF SMhb57zzDInHhYHHf5F2pl6AljRdrKIhE+Yls0PE4ZrA1nwruTI87jaGJPnp3qW7z07b Or94vDLN6uIHNx1dlg15Jz+oO+rORHag/d1E16UtMIEanz7gMdGJuhQqatrqL3mKOFDS iKLbLFhBkXPsSeO/zuMTgWLe/zAXH0DSvuuw5rncC81GIKZoYCK8GTcliTRsSM9Odt4X 1lNw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id j20si64341wmq.2.2021.10.04.09.25.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Oct 2021 09:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 194GPS22021934 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Oct 2021 18:25:28 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 194GPSYH007549; Mon, 4 Oct 2021 18:25:28 +0200 Date: Mon, 4 Oct 2021 18:25:27 +0200 From: Henning Schild To: Anton Mikanovich Cc: Michael Ebel , isar-users Subject: Re: [PATCH] meta/classes/debianize: Create debian folder if source does not contain one Message-ID: <20211004182527.7d092f0f@md1za8fc.ad001.siemens.net> In-Reply-To: <44068288-664e-ab9d-aaa0-bcd8b529897c@ilbers.de> References: <01271061-bcfd-4fa7-9c8a-1e54fa0d6817n@googlegroups.com> <44068288-664e-ab9d-aaa0-bcd8b529897c@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: l2VhcKdrV9Qu Am Wed, 29 Sep 2021 18:53:52 +0300 schrieb Anton Mikanovich : > On 29.09.21 17:43, Michael Ebel wrote: > > From e4f8153bd3b3886b283ea19517b56f5190ca6b9a Mon Sep 17 00:00:00 > > 2001 From: Michael Ebel > > Date: Wed, 29 Sep 2021 16:29:40 +0200 > > Subject: [PATCH] meta/classes/debianize: Create debian folder if=20 > > source does > > =C2=A0not contain one > > > > Signed-off-by: Michael Ebel > > --- > > =C2=A0meta/classes/debianize.bbclass | 5 +++++ > > =C2=A01 file changed, 5 insertions(+) > > > > diff --git a/meta/classes/debianize.bbclass=20 > > b/meta/classes/debianize.bbclass > > index 4486778..338b1f5 100644 > > --- a/meta/classes/debianize.bbclass > > +++ b/meta/classes/debianize.bbclass > > @@ -88,6 +88,11 @@ EOF > > =C2=A0} > > > > =C2=A0deb_debianize() { > > +=C2=A0=C2=A0 =C2=A0# create the debian folder if the source does not c= ontain it > > +=C2=A0=C2=A0 =C2=A0if [ ! -d ${S}/debian ]; then > > +=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0install -v -m 755 -d ${S}/debian > > +=C2=A0=C2=A0 =C2=A0fi > > + > > =C2=A0=C2=A0=C2=A0 =C2=A0# create the compat-file if there is no file w= ith that name in=20 > > WORKDIR > > =C2=A0=C2=A0=C2=A0 =C2=A0if [ -f ${WORKDIR}/compat ]; then > > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0install -v -m 644 ${WORKDIR= }/compat ${S}/debian/compat > > --=20 > > 2.25.1 =20 >=20 > Using flag `task_function[cleandirs] +=3D "${S}/debian"` looks much > cleaner. You can look at > meta-isar/recipes-app/samefile/samefile_2.14.bb for the reference. In general using cleandirs is probably the nicer solution, but that is on recipe level and depends on whether one really wants it to be cleaned. You can also imagine "SRC_URI =3D file:///debian" where a pre-filled folder is fetched and that task should not clean. So the patch is valid, there is code placing files in a potentially non-existing directory, which should be created on demand. Henning