public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Uladzimir Bely <ubely@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH v2 0/1] Improving base-apt usage
Date: Tue, 5 Oct 2021 10:36:42 +0200	[thread overview]
Message-ID: <20211005103642.2d3bf31f@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20211001091329.12979-1-ubely@ilbers.de>

Am Fri,  1 Oct 2021 11:13:28 +0200
schrieb Uladzimir Bely <ubely@ilbers.de>:

> Changes since v1:
>  - rebased on latest next
>  - updated patchset description
> 
> Currently, base-apt is used in the following way:
> * At first build every deb file that took part in installing is
> cached in directory $DL_DIR/deb/. Debootstrap is done from remote
> source.
> * At second build, `base-apt` repo is created from previously
> downloaded debs (if ISAR_USE_CACHED_BASE_REPO is set). Debootstrap
> and installing packages later is done from this local repo
> 
> The idea of this patchset is to precreate `base-apt` at first build
> and use it later for all steps. So, no second build will be required.
> 
> Currently, only debootstrap part is supported, all build-deps are
> still installed as before.

I do not get where the improvement is. A second offline run is _always_
useful to verify the cache is complete and can be used for a rebuild.
If one just wants that cache ... one would only run that base-apt task
in the second run. So a fast path without real build is supported. We
could even run that base-apt task at the end of the first run ... it
used to be an optional task at the end before i moved it to the front.

Since your code is not "complete" and just taking care of part of the
problem (which to me is not even clear) ... i am against merging that.

There is debugging leftofters in the code, but i did not look too deep
yet. And it seems like a lot of host leakage is coming into play with
the use of the python libs. That weird difference between
ubuntu/raspbian and debian is one example. So now one can not run isar
on ubuntu anymore ... (not sure if it worked before ... but would be
nice if it could).

Henning

> In future, there are plans to switch from debootstrap to mmdebstrap
> that is able to work without sudo and uses more clean
> (apt/python-apt) approach in comparison with debootstrap.
> 
> Uladzimir Bely (1):
>   [meta] Use cached base-apt repo to debootstrap
> 
>  meta-isar/conf/distro/ubuntu-focal.conf       |   4 +
>  meta-isar/conf/distro/ubuntu.public.key       |  53 +++++
>  .../isar-bootstrap/isar-bootstrap.inc         |  35 ++-
>  scripts/debrepo.py                            | 216
> ++++++++++++++++++ 4 files changed, 307 insertions(+), 1 deletion(-)
>  create mode 100644 meta-isar/conf/distro/ubuntu.public.key
>  create mode 100644 scripts/debrepo.py
> 


      parent reply	other threads:[~2021-10-05  8:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  9:13 Uladzimir Bely
2021-10-01  9:13 ` [PATCH v2 1/1] [meta] Use cached base-apt repo to debootstrap Uladzimir Bely
2021-10-05  8:36 ` Henning Schild [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005103642.2d3bf31f@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox